Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Issue 601103002: Whitelist instead of restricting to components for fileBrowserPrivate. (Closed)

Created:
6 years, 3 months ago by mtomasz
Modified:
6 years, 2 months ago
Reviewers:
miket_OOO, hirono
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, yoshiki+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Whitelist instead of restricting to components for fileBrowserPrivate. It is impossible to whitelist an extension which is note a component, when the api is restricted to components. Since we need to whitelist such regular extension, this patch removes the location restriction and whitelists all clients of this API. Along the way, id testing extensions using this api has been changed to a new one, since it was reused with other tests not related to the api. TEST=browser_tests: *FileBrowser*, *FileManager* BUG=None Committed: https://crrev.com/a8f8c2d4210aae4420ca6a751b2996dc0f36d358 Cr-Commit-Position: refs/heads/master@{#296823}

Patch Set 1 #

Patch Set 2 : Fixed. #

Patch Set 3 : Fixed tests. #

Patch Set 4 : Added comments with extension ids to manifests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -29 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/drive_search_test/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/file_watcher_test/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/filehandler_create/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/filehandler_create/test.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/filesystem_file_origin_url/background.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/filesystem_file_origin_url/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/filesystem_operations_test/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/handler_test_runner/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/mount_test/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/multi_profile_copy/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/big_file/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/copy_entry/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/create_directory/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/create_file/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/delete_entry/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/evil/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/extension/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/get_all/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/get_metadata/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mime_type/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mime_type/test.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mount/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/move_entry/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_directory/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_file/manifest.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
mtomasz
@miket: PTAL at chrome/common/extensions/api/_permission_features.json. @hirono: PTAL at everything else. Thanks.
6 years, 3 months ago (2014-09-25 05:06:06 UTC) #2
hirono
On 2014/09/25 05:06:06, mtomasz wrote: > @miket: PTAL at chrome/common/extensions/api/_permission_features.json. > @hirono: PTAL at everything ...
6 years, 3 months ago (2014-09-25 05:22:09 UTC) #3
hirono
On 2014/09/25 05:22:09, hirono wrote: > On 2014/09/25 05:06:06, mtomasz wrote: > > @miket: PTAL ...
6 years, 2 months ago (2014-09-25 09:10:50 UTC) #4
mtomasz
On 2014/09/25 09:10:50, hirono wrote: > On 2014/09/25 05:22:09, hirono wrote: > > On 2014/09/25 ...
6 years, 2 months ago (2014-09-25 09:43:40 UTC) #5
hirono
On 2014/09/25 09:43:40, mtomasz wrote: > On 2014/09/25 09:10:50, hirono wrote: > > On 2014/09/25 ...
6 years, 2 months ago (2014-09-25 10:12:09 UTC) #6
miket_OOO
> @miket: PTAL at chrome/common/extensions/api/_permission_features.json. This file LGTM
6 years, 2 months ago (2014-09-25 16:45:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601103002/60001
6 years, 2 months ago (2014-09-25 23:06:48 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 79d29ee1ae86731221e3c228dd1deed53b7cb595
6 years, 2 months ago (2014-09-25 23:20:56 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 23:21:42 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a8f8c2d4210aae4420ca6a751b2996dc0f36d358
Cr-Commit-Position: refs/heads/master@{#296823}

Powered by Google App Engine
This is Rietveld 408576698