Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1917)

Unified Diff: Source/core/rendering/svg/RenderSVGContainer.h

Issue 601093002: Move SVG container paint code to SVGContainerPainter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address reviewer comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/SVGContainerPainter.cpp ('k') | Source/core/rendering/svg/RenderSVGContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/svg/RenderSVGContainer.h
diff --git a/Source/core/rendering/svg/RenderSVGContainer.h b/Source/core/rendering/svg/RenderSVGContainer.h
index bead1b0c30b7e5b6a9b66e444fd92f75e31ddc17..c7c6b4043ae837f535ad0454bd44fc7f55294601 100644
--- a/Source/core/rendering/svg/RenderSVGContainer.h
+++ b/Source/core/rendering/svg/RenderSVGContainer.h
@@ -39,12 +39,17 @@ public:
void slowFirstChild() const WTF_DELETED_FUNCTION;
void slowLastChild() const WTF_DELETED_FUNCTION;
+ RenderObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); }
+ RenderObject* lastChild() const { ASSERT(children() == virtualChildren()); return children()->lastChild(); }
virtual void paint(PaintInfo&, const LayoutPoint&) override;
virtual void setNeedsBoundariesUpdate() override final { m_needsBoundariesUpdate = true; }
virtual bool didTransformToRootUpdate() { return false; }
bool isObjectBoundingBoxValid() const { return m_objectBoundingBoxValid; }
+ virtual FloatRect paintInvalidationRectInLocalCoordinates() const override final { return m_paintInvalidationBoundingBox; }
+ bool selfWillPaint();
+
protected:
virtual RenderObjectChildList* virtualChildren() override final { return children(); }
virtual const RenderObjectChildList* virtualChildren() const override final { return children(); }
@@ -60,27 +65,21 @@ protected:
virtual FloatRect objectBoundingBox() const override final { return m_objectBoundingBox; }
virtual FloatRect strokeBoundingBox() const override final { return m_strokeBoundingBox; }
- virtual FloatRect paintInvalidationRectInLocalCoordinates() const override final { return m_paintInvalidationBoundingBox; }
virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint& pointInParent, HitTestAction) override;
- // Allow RenderSVGTransformableContainer to hook in at the right time in layout()
+ // Allow RenderSVGTransformableContainer to hook in at the right time in layout().
virtual bool calculateLocalTransform() { return false; }
- // Allow RenderSVGViewportContainer to hook in at the right times in layout(), paint() and nodeAtFloatPoint()
+ // Allow RenderSVGViewportContainer to hook in at the right times in layout() and nodeAtFloatPoint().
virtual void calcViewport() { }
- virtual void applyViewportClip(PaintInfo&) { }
virtual bool pointIsInsideViewportClip(const FloatPoint& /*pointInParent*/) { return true; }
virtual void determineIfLayoutSizeChanged() { }
- bool selfWillPaint();
void updateCachedBoundaries();
private:
- RenderObject* firstChild() const { ASSERT(children() == virtualChildren()); return children()->firstChild(); }
- RenderObject* lastChild() const { ASSERT(children() == virtualChildren()); return children()->lastChild(); }
-
const RenderObjectChildList* children() const { return &m_children; }
RenderObjectChildList* children() { return &m_children; }
« no previous file with comments | « Source/core/paint/SVGContainerPainter.cpp ('k') | Source/core/rendering/svg/RenderSVGContainer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698