Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: Source/core/rendering/svg/RenderSVGContainer.h

Issue 601093002: Move SVG container paint code to SVGContainerPainter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/svg/RenderSVGContainer.h
diff --git a/Source/core/rendering/svg/RenderSVGContainer.h b/Source/core/rendering/svg/RenderSVGContainer.h
index e63989737d8d7656d3516b05de39ded40e4638d9..623dec914ca44bee25f6f8c57ada0d7e85ac3b6a 100644
--- a/Source/core/rendering/svg/RenderSVGContainer.h
+++ b/Source/core/rendering/svg/RenderSVGContainer.h
@@ -50,6 +50,9 @@ public:
virtual bool didTransformToRootUpdate() { return false; }
bool isObjectBoundingBoxValid() const { return m_objectBoundingBoxValid; }
+ virtual FloatRect paintInvalidationRectInLocalCoordinates() const OVERRIDE FINAL { return m_paintInvalidationBoundingBox; }
+ bool selfWillPaint();
+
protected:
virtual RenderObjectChildList* virtualChildren() OVERRIDE FINAL { return children(); }
virtual const RenderObjectChildList* virtualChildren() const OVERRIDE FINAL { return children(); }
@@ -65,21 +68,18 @@ protected:
virtual FloatRect objectBoundingBox() const OVERRIDE FINAL { return m_objectBoundingBox; }
virtual FloatRect strokeBoundingBox() const OVERRIDE FINAL { return m_strokeBoundingBox; }
- virtual FloatRect paintInvalidationRectInLocalCoordinates() const OVERRIDE FINAL { return m_paintInvalidationBoundingBox; }
virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint& pointInParent, HitTestAction) OVERRIDE;
// Allow RenderSVGTransformableContainer to hook in at the right time in layout()
virtual bool calculateLocalTransform() { return false; }
- // Allow RenderSVGViewportContainer to hook in at the right times in layout(), paint() and nodeAtFloatPoint()
+ // Allow RenderSVGViewportContainer to hook in at the right times in layout() and nodeAtFloatPoint().
virtual void calcViewport() { }
- virtual void applyViewportClip(PaintInfo&) { }
f(malita) 2014/09/25 13:42:50 Can you explain why de-encapsulating applyViewport
pdr. 2014/10/08 20:45:31 Our goal here is to move all paint-related code in
virtual bool pointIsInsideViewportClip(const FloatPoint& /*pointInParent*/) { return true; }
virtual void determineIfLayoutSizeChanged() { }
- bool selfWillPaint();
void updateCachedBoundaries();
private:

Powered by Google App Engine
This is Rietveld 408576698