Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: Source/core/rendering/svg/RenderSVGViewportContainer.cpp

Issue 601093002: Move SVG container paint code to SVGContainerPainter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address reviewer comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/svg/RenderSVGViewportContainer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. 5 * Copyright (C) 2009 Google, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
11 * 11 *
12 * This library is distributed in the hope that it will be useful, 12 * This library is distributed in the hope that it will be useful,
13 * but WITHOUT ANY WARRANTY; without even the implied warranty of 13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15 * Library General Public License for more details. 15 * Library General Public License for more details.
16 * 16 *
17 * You should have received a copy of the GNU Library General Public License 17 * You should have received a copy of the GNU Library General Public License
18 * along with this library; see the file COPYING.LIB. If not, write to 18 * along with this library; see the file COPYING.LIB. If not, write to
19 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 19 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
20 * Boston, MA 02110-1301, USA. 20 * Boston, MA 02110-1301, USA.
21 */ 21 */
22 22
23 #include "config.h" 23 #include "config.h"
24 #include "core/rendering/svg/RenderSVGViewportContainer.h" 24 #include "core/rendering/svg/RenderSVGViewportContainer.h"
25 25
26 #include "core/paint/SVGContainerPainter.h"
26 #include "core/rendering/PaintInfo.h" 27 #include "core/rendering/PaintInfo.h"
27 #include "core/rendering/svg/SVGRenderSupport.h" 28 #include "core/rendering/svg/SVGRenderSupport.h"
28 #include "core/svg/SVGSVGElement.h" 29 #include "core/svg/SVGSVGElement.h"
29 #include "core/svg/SVGUseElement.h" 30 #include "core/svg/SVGUseElement.h"
30 #include "platform/graphics/GraphicsContext.h" 31 #include "platform/graphics/GraphicsContext.h"
31 32
32 namespace blink { 33 namespace blink {
33 34
34 RenderSVGViewportContainer::RenderSVGViewportContainer(SVGElement* node) 35 RenderSVGViewportContainer::RenderSVGViewportContainer(SVGElement* node)
35 : RenderSVGContainer(node) 36 : RenderSVGContainer(node)
36 , m_didTransformToRootUpdate(false) 37 , m_didTransformToRootUpdate(false)
37 , m_isLayoutSizeChanged(false) 38 , m_isLayoutSizeChanged(false)
38 , m_needsTransformUpdate(true) 39 , m_needsTransformUpdate(true)
39 { 40 {
40 } 41 }
41 42
42 void RenderSVGViewportContainer::determineIfLayoutSizeChanged() 43 void RenderSVGViewportContainer::determineIfLayoutSizeChanged()
43 { 44 {
44 ASSERT(element()); 45 ASSERT(element());
45 if (!isSVGSVGElement(*element())) 46 if (!isSVGSVGElement(*element()))
46 return; 47 return;
47 48
48 m_isLayoutSizeChanged = toSVGSVGElement(element())->hasRelativeLengths() && selfNeedsLayout(); 49 m_isLayoutSizeChanged = toSVGSVGElement(element())->hasRelativeLengths() && selfNeedsLayout();
49 } 50 }
50 51
51 void RenderSVGViewportContainer::applyViewportClip(PaintInfo& paintInfo)
52 {
53 if (SVGRenderSupport::isOverflowHidden(this))
54 paintInfo.context->clip(m_viewport);
55 }
56
57 void RenderSVGViewportContainer::calcViewport() 52 void RenderSVGViewportContainer::calcViewport()
58 { 53 {
59 SVGElement* element = this->element(); 54 SVGElement* element = this->element();
60 ASSERT(element); 55 ASSERT(element);
61 if (!isSVGSVGElement(*element)) 56 if (!isSVGSVGElement(*element))
62 return; 57 return;
63 SVGSVGElement* svg = toSVGSVGElement(element); 58 SVGSVGElement* svg = toSVGSVGElement(element);
64 FloatRect oldViewport = m_viewport; 59 FloatRect oldViewport = m_viewport;
65 60
66 SVGLengthContext lengthContext(element); 61 SVGLengthContext lengthContext(element);
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 { 93 {
99 // Respect the viewport clip (which is in parent coords) 94 // Respect the viewport clip (which is in parent coords)
100 if (!SVGRenderSupport::isOverflowHidden(this)) 95 if (!SVGRenderSupport::isOverflowHidden(this))
101 return true; 96 return true;
102 97
103 return m_viewport.contains(pointInParent); 98 return m_viewport.contains(pointInParent);
104 } 99 }
105 100
106 void RenderSVGViewportContainer::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset) 101 void RenderSVGViewportContainer::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
107 { 102 {
108 ASSERT(element()); 103 SVGContainerPainter(*this).paint(paintInfo);
109 // An empty viewBox disables rendering.
110 if (isSVGSVGElement(*element()) && toSVGSVGElement(*element()).hasEmptyViewB ox())
111 return;
112
113 RenderSVGContainer::paint(paintInfo, paintOffset);
114 } 104 }
115 105
116 } 106 }
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGViewportContainer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698