Enable a11y audit for chrome://print and fix failing tests.

chrome/browser/resources/print_preview/previewarea/preview_area.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{accessibility: Function,
  *            documentLoadComplete: Function,
  *            getHeight: Function,
  *            getHorizontalScrollbarThickness: Function,
  *            getPageLocationNormalized: Function,
@@ skipping 181 matching lines @@
   PreviewArea.Classes_ = {
     COMPATIBILITY_OBJECT: 'preview-area-compatibility-object',
     OUT_OF_PROCESS_COMPATIBILITY_OBJECT:
         'preview-area-compatibility-object-out-of-process',
     CUSTOM_MESSAGE_TEXT: 'preview-area-custom-message-text',
     MESSAGE: 'preview-area-message',
     INVISIBLE: 'invisible',
     OPEN_SYSTEM_DIALOG_BUTTON: 'preview-area-open-system-dialog-button',
     OPEN_SYSTEM_DIALOG_BUTTON_THROBBER:
         'preview-area-open-system-dialog-button-throbber',
-    OVERLAY: 'preview-area-overlay-layer'
+    OVERLAY: 'preview-area-overlay-layer',
+    OVERLAYED: 'preview-area-overlayed',
+    MARGIN_CONTROL: 'margin-control',
+    PREVIEW_AREA: 'preview-area-plugin-wrapper'
   };
 
   /**
    * Enumeration of IDs shown in the preview area.
    * @enum {string}
    * @private
    */
   PreviewArea.MessageId_ = {
     CUSTOM: 'custom',
     LOADING: 'loading',
@@ skipping 284 matching lines @@
         var customMessageTextEl = this.getElement().getElementsByClassName(
             PreviewArea.Classes_.CUSTOM_MESSAGE_TEXT)[0];
         customMessageTextEl.textContent = opt_message;
       } else if (messageId == PreviewArea.MessageId_.LOADING) {
         jumpingDotsEl.classList.add('jumping-dots');
       }
       var messageEl = this.getElement().getElementsByClassName(
             PreviewArea.MessageIdClassMap_[messageId])[0];
       setIsVisible(messageEl, true);
 
-      // Show overlay.
-      this.overlayEl_.classList.remove(PreviewArea.Classes_.INVISIBLE);
+      this.setOverlayVisible_(true);
     },
 
     /**
-     * Hides the message overlay.
+     * Set the visibility of the message overlay.

[Dan Beam, 2014/10/21 01:16:31]

@param {boolean} visible Whether to make the overlay visible or not.

[hcarmona, 2014/10/21 21:32:37]

Done.

      * @private
      */
-    hideOverlay_: function() {
-      this.overlayEl_.classList.add(PreviewArea.Classes_.INVISIBLE);
-      // Disable jumping animation to conserve cycles.
-      var jumpingDotsEl = this.getElement().querySelector(
-          '.preview-area-loading-message-jumping-dots');
-      jumpingDotsEl.classList.remove('jumping-dots');
+    setOverlayVisible_: function(visible) {
+      this.overlayEl_.classList.toggle(
+          PreviewArea.Classes_.INVISIBLE,
+          !visible);
+
+      // Hide/show all controls that will overlap when the overlay is visible.
+      var marginControls = this.getElement().getElementsByClassName(
+          PreviewArea.Classes_.MARGIN_CONTROL);
+      for (var i = 0; i < marginControls.length; ++i) {
+        marginControls[i].classList.toggle(
+            PreviewArea.Classes_.OVERLAYED,
+            visible);

[Dan Beam, 2014/10/21 01:16:31]

nit:

  marginControls[i].classList.toggle(PreviewArea.Classes_.OVERLAYED, visible);

or

  marginControls[i].classList.toggle(PreviewArea.Classes_.OVERLAYED,
                                     visible);

are both less lines (if they fit)

[hcarmona, 2014/10/21 21:32:37]

Done.

+      }
+      var previewAreaControls = this.getElement().getElementsByClassName(
+          PreviewArea.Classes_.PREVIEW_AREA);
+      for (var i = 0; i < previewAreaControls.length; ++i) {
+        previewAreaControls[i].classList.toggle(
+            PreviewArea.Classes_.OVERLAYED,
+            visible);
+      }
+
+      if (!visible) {
+        // Disable jumping animation to conserve cycles.
+        var jumpingDotsEl = this.getElement().querySelector(
+            '.preview-area-loading-message-jumping-dots');
+        jumpingDotsEl.classList.remove('jumping-dots');
+      }
     },
 
     /**
      * Creates a preview plugin and adds it to the DOM.
      * @param {string} srcUrl Initial URL of the plugin.
      * @private
      */
     createPlugin_: function(srcUrl) {
       if (this.plugin_) {
         console.warn('Pdf preview plugin already created');
@@ skipping 176 matching lines @@
         this.plugin_.setPageNumbers(JSON.stringify(
             this.printTicketStore_.pageRange.getPageNumberSet().asArray()));
         if (this.zoomLevel_ != null && this.pageOffset_ != null) {
           this.plugin_.setZoomLevel(this.zoomLevel_);
           this.plugin_.setPageXOffset(this.pageOffset_.x);
           this.plugin_.setPageYOffset(this.pageOffset_.y);
         } else {
           this.plugin_.fitToHeight();
         }
       }
-      this.hideOverlay_();
+      this.setOverlayVisible_(false);
       this.isPluginReloaded_ = true;
       this.dispatchPreviewGenerationDoneIfReady_();
     },
 
     /**
      * Called when the preview plugin's visual state has changed. This is a
      * consequence of scrolling or zooming the plugin. Updates the custom
      * margins component if shown.
      * @private
      */
@@ skipping 43 matching lines @@
             new print_preview.Size(viewportWidth, viewportHeight));
       }
     }
   };
 
   // Export
   return {
     PreviewArea: PreviewArea
   };
 });