Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 601083002: Allow WebRTC tests that watch for black frames to be off by one. (Closed)

Created:
6 years, 2 months ago by rileya (GONE FROM CHROMIUM)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow WebRTC tests that watch for black frames to be off by one. This leaves some room for YUV conversion rounding errors. BUG=91208 Committed: https://crrev.com/6cc2c20cc7ae7d7b7e72db77bddead6daa7a7b77 Cr-Commit-Position: refs/heads/master@{#296677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/test/data/media/webrtc_test_utilities.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
rileya (GONE FROM CHROMIUM)
I'm working on GPU YUV conversion for video->canvas copies. Sadly, differences in GPU/platform/etc mean we ...
6 years, 2 months ago (2014-09-25 03:47:25 UTC) #2
perkj_chrome
lgtm lgtm
6 years, 2 months ago (2014-09-25 06:39:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601083002/1
6 years, 2 months ago (2014-09-25 06:40:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 86589ddc34f699c51855dfbc3c9dc096f62b2c66
6 years, 2 months ago (2014-09-25 07:39:05 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6cc2c20cc7ae7d7b7e72db77bddead6daa7a7b77 Cr-Commit-Position: refs/heads/master@{#296677}
6 years, 2 months ago (2014-09-25 07:39:38 UTC) #7
phoglund_chromium
6 years, 2 months ago (2014-09-25 09:45:10 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698