Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2179)

Unified Diff: device/usb/usb_service_unittest.cc

Issue 601073002: Move string descriptor getters from UsbDeviceHandle to UsbDevice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/usb/usb_service_unittest.cc
diff --git a/device/usb/usb_service_unittest.cc b/device/usb/usb_service_unittest.cc
index 543620026fbc54a0845bef3754c963b6bae3ef3f..e8affa0522c3fff91aefeedccf855d787573079c 100644
--- a/device/usb/usb_service_unittest.cc
+++ b/device/usb/usb_service_unittest.cc
@@ -29,23 +29,16 @@ TEST_F(UsbServiceTest, ClaimGadget) {
scoped_ptr<UsbTestGadget> gadget = UsbTestGadget::Claim();
ASSERT_TRUE(gadget.get());
- scoped_refptr<UsbDeviceHandle> handle = gadget->GetDevice()->Open();
-
+ scoped_refptr<UsbDevice> device = gadget->GetDevice();
base::string16 utf16;
- ASSERT_TRUE(handle->GetManufacturer(&utf16));
- ASSERT_EQ("Google Inc.", base::UTF16ToUTF8(utf16));
- // Check again to make sure string descriptor caching works.
+ ASSERT_TRUE(device->GetManufacturer(&utf16));
ASSERT_EQ("Google Inc.", base::UTF16ToUTF8(utf16));
- ASSERT_TRUE(handle->GetProduct(&utf16));
- ASSERT_EQ("Test Gadget (default state)", base::UTF16ToUTF8(utf16));
- // Check again to make sure string descriptor caching works.
+ ASSERT_TRUE(device->GetProduct(&utf16));
ASSERT_EQ("Test Gadget (default state)", base::UTF16ToUTF8(utf16));
- ASSERT_TRUE(handle->GetSerial(&utf16));
- ASSERT_EQ(gadget->GetSerial(), base::UTF16ToUTF8(utf16));
- // Check again to make sure string descriptor caching works.
- ASSERT_EQ(gadget->GetSerial(), base::UTF16ToUTF8(utf16));
+ ASSERT_TRUE(device->GetSerialNumber(&utf16));
+ ASSERT_EQ(gadget->GetSerialNumber(), base::UTF16ToUTF8(utf16));
}
TEST_F(UsbServiceTest, DisconnectAndReconnect) {

Powered by Google App Engine
This is Rietveld 408576698