Merge 53506 - 20100119 Carol Szabo <carol.szabo@nokia.com>...

Merge 53506 - 20100119  Carol Szabo  <carol.szabo@nokia.com>;

        Reviewed by Darin Adler.

        Another crazy counters bug
        https://bugs.webkit.org/show_bug.cgi?id=11031
        Added tests for dynamic DOM changes affecting counters.

        * fast/css/counters/counterincrement002.html: Added.
        * fast/css/counters/counterreset000.html: Added.
        * fast/css/counters/counterreset002.html: Added.
        * fast/css/counters/counterincrement002expected.txt: Added.
        * fast/css/counters/counterreset000expected.txt: Added.
        * fast/css/counters/counterreset002expected.txt: Added.
20100119  Carol Szabo  <carol.szabo@nokia.com>;

        Reviewed by Darin Adler.

        Another crazy counters bug
        https://bugs.webkit.org/show_bug.cgi?id=11031

        This patch actually provides for counter updating when the style
        of a renderer changes.

        Tests: fast/css/counters/counterincrement002.html
               fast/css/counters/counterreset000.html
               fast/css/counters/counterreset002.html

        * rendering/RenderCounter.cpp:
        (WebCore::RenderCounter::rendererStyleChanged):
        This function is added to update the counter hierarchy in
        response to changes to the style of a renderer.
        * rendering/RenderCounter.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::styleDidChange):
        For changes that may include the counter directives added a
        call to RenderCounter::rendererStyleChanged.

TBR=laforge@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38931

[laforge, 2010-02-12 21:00:47]

LGTM

On Fri, Feb 12, 2010 at 12:40 PM, <cevans@chromium.org> wrote:

> Reviewers: laforge,
>
> Description:
> Merge 53506 - 20100119  Carol Szabo  <carol.szabo@nokia.com>
>
>        Reviewed by Darin Adler.
>
>        Another crazy counters bug
>        https://bugs.webkit.org/show_bug.cgi?id=11031
>        Added tests for dynamic DOM changes affecting counters.
>
>        * fast/css/counters/counterincrement002.html: Added.
>        * fast/css/counters/counterreset000.html: Added.
>        * fast/css/counters/counterreset002.html: Added.
>        * fast/css/counters/counterincrement002expected.txt: Added.
>        * fast/css/counters/counterreset000expected.txt: Added.
>        * fast/css/counters/counterreset002expected.txt: Added.
> 20100119  Carol Szabo  <carol.szabo@nokia.com>
>
>        Reviewed by Darin Adler.
>
>        Another crazy counters bug
>        https://bugs.webkit.org/show_bug.cgi?id=11031
>
>        This patch actually provides for counter updating when the style
>        of a renderer changes.
>
>        Tests: fast/css/counters/counterincrement002.html
>               fast/css/counters/counterreset000.html
>               fast/css/counters/counterreset002.html
>
>        * rendering/RenderCounter.cpp:
>        (WebCore::RenderCounter::rendererStyleChanged):
>        This function is added to update the counter hierarchy in
>        response to changes to the style of a renderer.
>        * rendering/RenderCounter.h:
>        * rendering/RenderObject.cpp:
>        (WebCore::RenderObject::styleDidChange):
>        For changes that may include the counter directives added a
>        call to RenderCounter::rendererStyleChanged.
>
> TBR=laforge@chromium.org
>
> Please review this at http://codereview.chromium.org/601062
>
> SVN Base: svn://chrome-svn/chrome/branches/WebKit/249/
>
> Affected files:
>  A     LayoutTests/fast/css/counters/counter-increment-002-expected.txt
>  A     LayoutTests/fast/css/counters/counter-increment-002.html
>  A     LayoutTests/fast/css/counters/counter-reset-000-expected.txt
>  A     LayoutTests/fast/css/counters/counter-reset-000.html
>  A     LayoutTests/fast/css/counters/counter-reset-002-expected.txt
>  A     LayoutTests/fast/css/counters/counter-reset-002.html
>  M     WebCore/rendering/RenderCounter.h
>  M     WebCore/rendering/RenderCounter.cpp
>  M     WebCore/rendering/RenderObject.cpp
>
>
>