Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 601033002: Fix memory leak in test (Closed)

Created:
6 years, 2 months ago by groby-ooo-7-16
Modified:
6 years, 2 months ago
Reviewers:
jiayl, Mark P, jiayul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@merge-results
Project:
chromium
Visibility:
Public.

Description

Fix memory leak in test BUG=none TBR=mpearson@chromium.org R=jiayul@chromium.org Committed: https://crrev.com/b49c29b0ee11c0228c0a5c210edcdff79e04bb12 Cr-Commit-Position: refs/heads/master@{#296604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/omnibox/base_search_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
groby-ooo-7-16
6 years, 2 months ago (2014-09-24 23:29:22 UTC) #1
jiayl
lgtm
6 years, 2 months ago (2014-09-24 23:30:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601033002/1
6 years, 2 months ago (2014-09-24 23:33:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/60386) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/65269) android_chromium_gn_compile_rel ...
6 years, 2 months ago (2014-09-24 23:39:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/601033002/1
6 years, 2 months ago (2014-09-24 23:46:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as cdce187af39fccdad6c8fc26c4e29e9eaa613c54
6 years, 2 months ago (2014-09-25 01:06:21 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b49c29b0ee11c0228c0a5c210edcdff79e04bb12 Cr-Commit-Position: refs/heads/master@{#296604}
6 years, 2 months ago (2014-09-25 01:06:54 UTC) #11
Mark P
6 years, 2 months ago (2014-09-25 16:05:12 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698