Add a template url accessor for contextual search that doesn't preload.

Add a template url accessor for contextual search that doesn't prefetch.

BUG=416225
Committed: https://crrev.com/8ab8c6d93cb113e7d20f2c4db11cf86aad73ad13
Cr-Commit-Position: refs/heads/master@{#296629}

[Donn Denman, 2014-09-24 22:46:18]

donnd@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org

[Donn Denman, 2014-09-24 22:46:19]

Pedro, I need this non-preloading capability for the long-press literal work I'm
doing downstream.  PTAL.  Thanks!

[pedro (no code reviews), 2014-09-24 23:18:17]

Hey Donn, I've made a suggestion to make it simpler. Let me know what you think.

https://codereview.chromium.org/601003002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
(right):

https://codereview.chromium.org/601003002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:229:
* The returned URL does not have the preload parameter set.
Instead of adding a new method here, and a new native method, why not extending
the existing native method to receive a shouldPreload boolean?

Then we could have two signatures for this method here:

getUrlForContextualSearchQuery(query, alternateTerm)
getUrlForContextualSearchQuery(query, alternateTerm, shouldPreload)

[Donn Denman, 2014-09-25 00:01:03]

PTAL, thanks!

https://codereview.chromium.org/601003002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
(right):

https://codereview.chromium.org/601003002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:229:
* The returned URL does not have the preload parameter set.
On 2014/09/24 23:18:17, pedrosimonetti wrote:
> Instead of adding a new method here, and a new native method, why not
extending
> the existing native method to receive a shouldPreload boolean?
> 
> Then we could have two signatures for this method here:
> 
> getUrlForContextualSearchQuery(query, alternateTerm)
> getUrlForContextualSearchQuery(query, alternateTerm, shouldPreload)

Done.

[pedro (no code reviews), 2014-09-25 00:16:10]

Just one more comment, otherwise it looks good.

https://codereview.chromium.org/601003002/diff/40001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
(right):

https://codereview.chromium.org/601003002/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:236:
public String getUrlForContextualSearchQuery(String query, String alternateTerm,
I think it would be nice keeping the previous signature (which would use the new
signature), otherwise it will brake ContextualSearch when it lands.

public String getUrlForContextualSearchQuery(query, alternateTerm) {
  return getUrlForContextualSearchQuery(query, alternateTerm, true);
}

[donnd, 2014-09-25 00:23:46]

donnd@google.com changed reviewers:
+ donnd@google.com

[donnd, 2014-09-25 00:23:47]

Thanks Pedro!

https://codereview.chromium.org/601003002/diff/40001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
(right):

https://codereview.chromium.org/601003002/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:236:
public String getUrlForContextualSearchQuery(String query, String alternateTerm,
On 2014/09/25 00:16:10, pedrosimonetti wrote:
> I think it would be nice keeping the previous signature (which would use the
new
> signature), otherwise it will brake ContextualSearch when it lands.
> 
> public String getUrlForContextualSearchQuery(query, alternateTerm) {
>   return getUrlForContextualSearchQuery(query, alternateTerm, true);
> }

Thanks for reminding me!  Done.

[donnd, 2014-09-25 00:27:37]

donnd@google.com changed reviewers:
+ yfriedman@chromium.org

[donnd, 2014-09-25 00:27:38]

Yaron, PTAL.  Thanks!

[Yaron, 2014-09-25 00:34:19]

lgtm

nit: update CL description to "prefetch" not "preload" to match the code

[donnd, 2014-09-25 00:50:19]

On 2014/09/25 00:34:19, Yaron wrote:
> lgtm
> 
> nit: update CL description to "prefetch" not "preload" to match the code

Done.  Thanks!

[donnd, 2014-09-25 00:50:25]

The CQ bit was checked by donnd@google.com

[commit-bot: I haz the power, 2014-09-25 00:52:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/601003002/60001

[commit-bot: I haz the power, 2014-09-25 02:18:09]

Committed patchset #4 (id:60001) as 72521deea427b2c88511b06f632bc0a79ae7931b

[commit-bot: I haz the power, 2014-09-25 02:18:44]

Patchset 4 (id:??) landed as
https://crrev.com/8ab8c6d93cb113e7d20f2c4db11cf86aad73ad13
Cr-Commit-Position: refs/heads/master@{#296629}