Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 600963002: [AiS] Update GN build, as well. (Closed)

Created:
6 years, 2 months ago by groby-ooo-7-16
Modified:
6 years, 2 months ago
Reviewers:
Mark P
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@merge-results
Project:
chromium
Visibility:
Public.

Description

[AiS] Update GN build, as well. Previous CL for adding base_search_provider_unittest.cc did not update BUILD.gn - this CL does. BUG=none TBR=mpearson@chromium.org Committed: https://crrev.com/5a9f3565384683a6c1f542d6ac6b4c5aa26995df Cr-Commit-Position: refs/heads/master@{#296538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/omnibox/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
groby-ooo-7-16
Heads up - fixed the GN build separately, since it was my first GN venture. ...
6 years, 2 months ago (2014-09-24 20:57:05 UTC) #1
Mark P
lgtm for the record sorry I didn't catch this during the review --mark
6 years, 2 months ago (2014-09-24 21:25:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600963002/1
6 years, 2 months ago (2014-09-24 21:31:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 260dcf41e5c9e2750b326cd67ddf5dc5efeafcd2
6 years, 2 months ago (2014-09-24 22:07:35 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 22:08:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a9f3565384683a6c1f542d6ac6b4c5aa26995df
Cr-Commit-Position: refs/heads/master@{#296538}

Powered by Google App Engine
This is Rietveld 408576698