Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 600953002: Allow nullptr use in Chromium. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, Ryan Sleevi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow nullptr use in Chromium. NOTRY=true Committed: https://crrev.com/8bc9fc166a9f23b90964cbad7e826c295112e222 Cr-Commit-Position: refs/heads/master@{#296509}

Patch Set 1 #

Total comments: 1

Patch Set 2 : nullptrallow: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M styleguide/c++/c++11.html View 1 2 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
danakj
6 years, 3 months ago (2014-09-24 20:12:45 UTC) #1
danakj
6 years, 3 months ago (2014-09-24 20:12:54 UTC) #3
danakj
6 years, 3 months ago (2014-09-24 20:13:53 UTC) #4
Nico
Thanks! Please remove "std::" from the CL description, as nullptr isn't in std. (Everything in ...
6 years, 3 months ago (2014-09-24 20:30:22 UTC) #5
danakj
ooh indeed. PTAL I think I did it right.
6 years, 3 months ago (2014-09-24 20:40:19 UTC) #6
Nico
lgtm!
6 years, 3 months ago (2014-09-24 20:42:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600953002/20001
6 years, 3 months ago (2014-09-24 20:44:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d37450b99aef8632c3374a09c484e94a1f23e9e5
6 years, 3 months ago (2014-09-24 20:45:37 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 20:46:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8bc9fc166a9f23b90964cbad7e826c295112e222
Cr-Commit-Position: refs/heads/master@{#296509}

Powered by Google App Engine
This is Rietveld 408576698