Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Issue 60094: Fix for issue 9685: (Closed)

Created:
11 years, 8 months ago by tedoc2000
Modified:
9 years, 7 months ago
Reviewers:
tony, Michael Moss, sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix for issue 9685: Use git log | grep .. instead of git svn info

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixup based on feedback #

Patch Set 3 : Better perl from ion_ #

Patch Set 4 : Missed /$1/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/tools/build/linux/version.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
tedoc2000
Here is a fix for issue 9685 that we discussed on IRC two nights ago.
11 years, 8 months ago (2009-04-03 15:48:18 UTC) #1
tedoc2000
Switch to sgk
11 years, 8 months ago (2009-04-03 15:57:57 UTC) #2
sgk
http://codereview.chromium.org/60094/diff/1/2 File chrome/tools/build/linux/version.sh (right): http://codereview.chromium.org/60094/diff/1/2#newcode30 Line 30: LASTCHANGE=$(git log | grep '^\s*git-svn-id:' 2>/dev/null | head ...
11 years, 8 months ago (2009-04-03 16:22:33 UTC) #3
tedoc2000
Fixed up based on sgk feedback
11 years, 8 months ago (2009-04-03 17:24:39 UTC) #4
sgk
lgtm
11 years, 8 months ago (2009-04-03 17:31:42 UTC) #5
tedoc2000
Got an improvement on the perl from ion_ on IRC
11 years, 8 months ago (2009-04-03 17:31:48 UTC) #6
tedoc2000
Missed $1 substitution.
11 years, 8 months ago (2009-04-03 17:46:57 UTC) #7
tony
I'm not opposed to this, but realize that the comment in the header says that ...
11 years, 8 months ago (2009-04-03 17:48:41 UTC) #8
Michael Moss
> It would probably be better to focus on that (most of our scripts are ...
11 years, 8 months ago (2009-04-03 17:51:11 UTC) #9
sgk
still lgtm w/$1 subst
11 years, 8 months ago (2009-04-03 18:09:41 UTC) #10
sgk
11 years, 8 months ago (2009-04-03 20:20:35 UTC) #11
Committed as r13101.  Thanks,

Powered by Google App Engine
This is Rietveld 408576698