Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 600913002: Revert of Large wallpaper decoding in utility process (Closed)

Created:
6 years, 2 months ago by jiayl
Modified:
6 years, 2 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org, jam, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Large wallpaper decoding in utility process (patchset #5 id:190001 of https://codereview.chromium.org/482163002/) Reason for revert: Speculative revert for unit_tests failures: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31845/steps/unit_tests/logs/DecodeImageSizeLimit Original issue's description: > Handle large wallpaper decoding in utility process: > Images over 32M pixels exceed IPC message limit size. In ChromeContentUtilityClient::DecodeImage(), cut image dimensions in half to minimize quality loss and allow decoded image to be returned via IPC message. > > BUG=366825 > TEST=ChromeContentUtilityClientTest.DecodeImageSizeLimit; Set ChromeOS wallpaper using JPGs attached to bug > > Committed: https://crrev.com/d9d0e601c4c45ec8f2fb1d148e68458d9baa4e24 > Cr-Commit-Position: refs/heads/master@{#296407} TBR=dcheng@chromium.org,bshe@chromium.org,skuhne@chromium.org,sky@chromium.org,tsepez@chromium.org,yoz@chromium.org,glevin@chromium.org NOTREECHECKS=true NOTRY=true BUG=366825 Committed: https://crrev.com/4ef72fa49c0650d716205c0686ee0268070281ff Cr-Commit-Position: refs/heads/master@{#296457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -136 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_function_base.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_install_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/image_decoder.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/image_decoder.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 3 chunks +7 lines, -41 lines 0 comments Download
D chrome/utility/chrome_content_utility_client_unittest.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jiayl
Created Revert of Large wallpaper decoding in utility process
6 years, 2 months ago (2014-09-24 17:52:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600913002/1
6 years, 2 months ago (2014-09-24 17:53:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as ca7cd59737f4ba85af448d7ffd28bbcfc2281eb8
6 years, 2 months ago (2014-09-24 17:54:58 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 17:55:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ef72fa49c0650d716205c0686ee0268070281ff
Cr-Commit-Position: refs/heads/master@{#296457}

Powered by Google App Engine
This is Rietveld 408576698