Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 600893002: PPAPI: Move PPB_Messaging 1.2 to stable (Closed)

Created:
6 years, 3 months ago by dmichael (off chromium)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

PPAPI: Move PPB_Messaging 1.2 to stable This adds postMessageAndAwaitResponse() support to Pepper stable. Open issues: 1) This is arguably an expansion on what JavaScript can do today. In particular, it would be possible to make JavaScript block on PNaCl, which blocks on another thread, which blocks on something like synchronous FileIO. 2) Not all types are supported yet; e.g. FileRef and FileSystem. I want to fix that prior to M39. (see https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/pepper/message_channel.cc&l=305) BUG=367896 Committed: https://crrev.com/9be4c268e89e2a759a670d55769defbd29bdd224 Cr-Commit-Position: refs/heads/master@{#297026}

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : remove from dev-channel #

Patch Set 4 : remove dev-channel check in message_channel.cc #

Patch Set 5 : unnecessary dependencies #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -21 lines) Patch
M content/renderer/pepper/message_channel.cc View 1 2 3 4 5 chunks +3 lines, -10 lines 0 comments Download
M ppapi/api/ppb_messaging.idl View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/api/ppp_message_handler.idl View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/ppb_messaging.h View 4 chunks +6 lines, -6 lines 2 comments Download
M ppapi/c/ppp_message_handler.h View 3 chunks +4 lines, -2 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev_channel.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_public_stable.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dmichael (off chromium)
6 years, 2 months ago (2014-09-26 18:37:41 UTC) #2
teravest
lgtm
6 years, 2 months ago (2014-09-26 20:03:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600893002/80001
6 years, 2 months ago (2014-09-26 20:13:46 UTC) #6
bbudge
lgtm
6 years, 2 months ago (2014-09-26 20:20:04 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 234479ec0a4383dc919b144f5fd2bc94c0e8d458
6 years, 2 months ago (2014-09-26 20:39:39 UTC) #8
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/9be4c268e89e2a759a670d55769defbd29bdd224 Cr-Commit-Position: refs/heads/master@{#297026}
6 years, 2 months ago (2014-09-26 20:40:20 UTC) #9
Junichi Uekawa
https://codereview.chromium.org/600893002/diff/80001/ppapi/c/ppb_messaging.h File ppapi/c/ppb_messaging.h (right): https://codereview.chromium.org/600893002/diff/80001/ppapi/c/ppb_messaging.h#newcode21 ppapi/c/ppb_messaging.h:21: #define PPB_MESSAGING_INTERFACE PPB_MESSAGING_INTERFACE_1_2 This makes an interface which was ...
6 years, 2 months ago (2014-10-10 00:56:01 UTC) #11
Junichi Uekawa
6 years, 2 months ago (2014-10-10 03:50:44 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/600893002/diff/80001/ppapi/c/ppb_messaging.h
File ppapi/c/ppb_messaging.h (right):

https://codereview.chromium.org/600893002/diff/80001/ppapi/c/ppb_messaging.h#...
ppapi/c/ppb_messaging.h:21: #define PPB_MESSAGING_INTERFACE
PPB_MESSAGING_INTERFACE_1_2
On 2014/10/10 00:56:00, Junichi Uekawa wrote:
> This makes an interface which was available since Sep 17 to stable, so any
code
> that gets compiled against this is going to fail running on stable chrome
> (get_interface returns 0).
> 
> I think this is a problem, but how is this usually done?

nevermind, my understanding now is that code compiled against this canary ppapi
will only work on canary chrome, and not with older chrome versions.

Powered by Google App Engine
This is Rietveld 408576698