Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 600863002: IDL: Make SerializedScriptValue arguments less of a special case (Closed)

Created:
6 years, 3 months ago by Jens Widell
Modified:
6 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Make SerializedScriptValue arguments less of a special case Remove the special handling of SerializedScriptValue arguments from the methods.cpp template, and instead fix the already existing handling in v8_types.py. The conversion uses an ExceptionState object to report exceptions, and is now handled like any other conversion that does that. BUG=413257 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182613

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M Source/bindings/scripts/v8_types.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +3 lines, -6 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
Jens Widell
PTAL It's worth pointing out that all uses of SerializedScriptValue in our IDL files (aside ...
6 years, 3 months ago (2014-09-24 14:59:07 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-24 15:11:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600863002/1
6 years, 3 months ago (2014-09-24 15:13:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/20454)
6 years, 3 months ago (2014-09-24 15:34:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600863002/1
6 years, 3 months ago (2014-09-24 15:45:21 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 16:33:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182613

Powered by Google App Engine
This is Rietveld 408576698