Issue 60085: Rewrote equality check in CompareStub to do quick pointer comparison first.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60085: Rewrote equality check in CompareStub to do quick pointer comparison first. (Closed)

Created:
11 years, 8 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Quick pointer comparison, removed undetectable tests. Special case for NaN in equality test.

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -65 lines)			Patch
	M	src/codegen-ia32.cc	View		1 chunk	+124 lines, -63 lines	1 comment	Download
	M	test/cctest/test-api.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

Assembler-review. Still waiting for up-to-date performance numbers. Seems to win on some, and lose on ...

11 years, 8 months ago (2009-04-03 09:48:18 UTC) #1

Erik Corry

11 years, 8 months ago (2009-04-03 12:31:55 UTC) #2

LGTM

http://codereview.chromium.org/60085/diff/1/2
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/60085/diff/1/2#newcode6540
Line 6540: // Try to read the first word of the heap-number. This is the high
Comment looks wrong.

Expand Messages | Collapse Messages