Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 600833002: Start building ui_base_unittests targets. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
cjhopman, sky, M-A Ruel
CC:
chromium-reviews, kalyank, klundberg+watch_chromium.org, sadrul, yfriedman+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Start building ui_base_unittests targets. This is in preparation for updating the buildbot code. First we need to make sure we build those targets, otherwise buildbot will fail. BUG=331829, 373148, 299841, 103304 TEST=None R=sky@chromium.org,maruel@chromium.org Committed: https://crrev.com/430fc906824927713d5a318afb50654e95b699b0 Cr-Commit-Position: refs/heads/master@{#296877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M build/all.gyp View 10 chunks +10 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
tfarina
Scott -> everything. Chris, please, review build/android changes.
6 years, 3 months ago (2014-09-24 13:03:53 UTC) #1
sky
LGTM
6 years, 2 months ago (2014-09-24 15:35:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600833002/1
6 years, 2 months ago (2014-09-25 15:52:46 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13474)
6 years, 2 months ago (2014-09-25 16:01:10 UTC) #6
tfarina
On 2014/09/25 16:01:10, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-09-25 16:05:41 UTC) #8
tfarina
TBR maruel for PRESUBMIT.py change. Please, rubber stamp? Thanks!
6 years, 2 months ago (2014-09-26 01:02:31 UTC) #10
M-A Ruel
lgtm
6 years, 2 months ago (2014-09-26 01:09:44 UTC) #11
tfarina
Stuart gave green light for this (patch set 1). Pushing to CQ.
6 years, 2 months ago (2014-09-26 04:03:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600833002/1
6 years, 2 months ago (2014-09-26 04:03:47 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as d935ba557b02ffd80ad489a29e22b46f00eb5e36
6 years, 2 months ago (2014-09-26 04:08:36 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/430fc906824927713d5a318afb50654e95b699b0 Cr-Commit-Position: refs/heads/master@{#296877}
6 years, 2 months ago (2014-09-26 04:09:51 UTC) #16
perkj_chrome
6 years, 2 months ago (2014-09-26 07:32:21 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/603413002/ by perkj@chromium.org.

The reason for reverting is: Breaks Android waterfall.
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29.

Powered by Google App Engine
This is Rietveld 408576698