Issue 60083018: Don't PushProperties every commit for animating layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60083018: Don't PushProperties every commit for animating layers (Closed)

Created:
7 years, 1 month ago by ajuma

Modified:
7 years, 1 month ago

Reviewers:
Ian Vollick

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't PushProperties every commit for animating layers This removes the need to PushProperties every commit during an animation. Instead, a single PushProperties is needed whenever there are animations waiting for deletion. This also removes LayerAnimationController::set_force_sync, which no longer had any non-test callers and wasn't actually needed by its test callers. BUG=259088 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235845

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -54 lines)			Patch
M	cc/animation/layer_animation_controller.h	View	1 2	3 chunks	+2 lines, -9 lines	0 comments	Download
M	cc/animation/layer_animation_controller.cc	View	1 2	7 chunks	+24 lines, -37 lines	0 comments	Download
M	cc/animation/layer_animation_controller_unittest.cc	View	1 2	7 chunks	+14 lines, -3 lines	0 comments	Download
M	cc/animation/layer_animation_value_observer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/layers/layer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/layers/layer.cc	View	1 2	3 chunks	+6 lines, -4 lines	0 comments	Download
M	cc/layers/layer_impl.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/layers/layer_impl.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/test/animation_test_common.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	cc/test/animation_test_common.cc	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/60083018/80001

7 years, 1 month ago (2013-11-18 20:55:04 UTC) #3

Message was sent while issue was closed.

Change committed as 235845

Expand Messages | Collapse Messages