Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 60083011: Remove InbandTextTrackPrivate/InbandTextTrackPrivateClient (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, nessy, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove InbandTextTrackPrivate/InbandTextTrackPrivateClient These interfaces were virtually identical to the Web* variants, so just use those directly. BUG=316172 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161632

Patch Set 1 #

Patch Set 2 : rebase on top of https://codereview.chromium.org/61763010/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -334 lines) Patch
M Source/core/html/HTMLMediaElement.h View 3 chunks +6 lines, -5 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 5 chunks +7 lines, -6 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.h View 1 1 chunk +11 lines, -7 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.cpp View 1 2 chunks +26 lines, -24 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D Source/platform/graphics/media/InbandTextTrackPrivate.h View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/platform/graphics/media/InbandTextTrackPrivateClient.h View 1 chunk +0 lines, -46 lines 0 comments Download
M Source/platform/graphics/media/MediaPlayer.h View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
D Source/web/InbandTextTrackPrivateImpl.h View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/web/InbandTextTrackPrivateImpl.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
Aaron, can you have a look at this before I bring in core owners? Please ...
7 years, 1 month ago (2013-11-07 14:13:32 UTC) #1
philipj_slow
On 2013/11/07 14:13:32, philipj wrote: > 2. The presubmit hook is not happy about including ...
7 years, 1 month ago (2013-11-07 15:13:12 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm. Thanks for doing this.
7 years, 1 month ago (2013-11-07 18:07:36 UTC) #3
philipj_slow
Jochen, can you take a look while the Californians sleep?
7 years, 1 month ago (2013-11-08 13:40:33 UTC) #4
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-08 13:51:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/60083011/50001
7 years, 1 month ago (2013-11-08 15:53:52 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 17:34:23 UTC) #7
Message was sent while issue was closed.
Change committed as 161632

Powered by Google App Engine
This is Rietveld 408576698