Issue 60083009: base: Remove call to g_get_home_dir() from GetHomeDir() for Chrome OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60083009: base: Remove call to g_get_home_dir() from GetHomeDir() for Chrome OS (Closed)

Created:
7 years, 1 month ago by satorux1

Modified:
7 years, 1 month ago

Reviewers:
awong

CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base: Remove call to g_get_home_dir() from GetHomeDir() for Chrome OS This is in preparation for removing a dependency to GLib. On a Chrome device, home directory is always set to /home/chronos/user as hard-coded in GetHomeDir(). On a linux workstation for testing, referencing $HOME is sufficient. BUG=240617 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233576

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	base/file_util_posix.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/60083009/1

7 years, 1 month ago (2013-11-07 03:54:15 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=221171

7 years, 1 month ago (2013-11-07 08:07:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/60083009/1

7 years, 1 month ago (2013-11-07 08:19:22 UTC) #5

Message was sent while issue was closed.

Change committed as 233576

Expand Messages | Collapse Messages