Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 600803002: Make ONCCertificateImporter async. (Closed)

Created:
6 years, 3 months ago by pneubeck (no reviews)
Modified:
6 years, 3 months ago
Reviewers:
Joao da Silva, eroman
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, eroman, davemoore+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_chromeos_gyp
Project:
chromium
Visibility:
Public.

Description

Make ONCCertificateImporter async. 2nd Reland of https://codereview.chromium.org/547553005/ after fixing memory issues. This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/ Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations. Now, the import itself is asychronous and calls back on completion. While there, this also removes the GMock of the importer. BUG=413219 TBR=eroman@chromium.org Committed: https://crrev.com/197fa5f4d6499ab91ae2435d82dda19fd60d9271 Cr-Commit-Position: refs/heads/master@{#296405}

Patch Set 1 #

Patch Set 2 : Applied fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -324 lines) Patch
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 18 chunks +92 lines, -74 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater.cc View 4 chunks +16 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 2 chunks +47 lines, -26 lines 0 comments Download
M chromeos/chromeos.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D chromeos/network/onc/mock_certificate_importer.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chromeos/network/onc/mock_certificate_importer.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer.h View 2 chunks +17 lines, -11 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.h View 4 chunks +38 lines, -27 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.cc View 13 chunks +117 lines, -79 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl_unittest.cc View 1 12 chunks +62 lines, -52 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pneubeck (no reviews)
this time verified with a local valgrind run.
6 years, 3 months ago (2014-09-24 12:50:59 UTC) #2
Joao da Silva
lgtm
6 years, 3 months ago (2014-09-24 13:20:17 UTC) #3
pneubeck (no reviews)
TBR'ing eroman@, because other files than the unit test didn't change.
6 years, 3 months ago (2014-09-24 13:22:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600803002/20001
6 years, 3 months ago (2014-09-24 13:23:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8ce00528fdaa8cf57cacf756dac14ea89f735974
6 years, 3 months ago (2014-09-24 13:51:17 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 13:51:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/197fa5f4d6499ab91ae2435d82dda19fd60d9271
Cr-Commit-Position: refs/heads/master@{#296405}

Powered by Google App Engine
This is Rietveld 408576698