Instrumented libraries: update the libnspr4 build script.

Instrumented libraries: update the libnspr4 build script.

There has been a security update in Precise which changed the paths somewhat.

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Committed: https://crrev.com/91e9dd404b29bcbb847b98530e83f3c40720b890
Cr-Commit-Position: refs/heads/master@{#296395}

[earthdok, 2014-09-24 12:40:23]

The CQ bit was checked by earthdok@chromium.org

[commit-bot: I haz the power, 2014-09-24 12:41:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600793002/1

[commit-bot: I haz the power, 2014-09-24 12:42:14]

Committed patchset #1 (id:1) as ffb1baf837df2e4530a1c4a85556451b650b1586

[commit-bot: I haz the power, 2014-09-24 12:43:07]

Patchset 1 (id:??) landed as
https://crrev.com/91e9dd404b29bcbb847b98530e83f3c40720b890
Cr-Commit-Position: refs/heads/master@{#296395}

[Alexander Potapenko, 2014-09-24 13:32:13]

lgtm

[Lei Zhang, 2014-09-24 17:47:41]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/598983004/ by thestig@chromium.org.

The reason for reverting is: MSAN bots failed.

FAILED: cd ../../third_party/instrumented_libraries;
../../third_party/instrumented_libraries/download_build_install.py
"--product-directory=../../out/Release" "--package=libnspr4"
"--intermediate-directory=../../out/Release/obj/third_party/instrumented_libraries/msan-libnspr4.gen"
"--sanitizer-type=msan" "--extra-configure-flags=--enable-64bit --disable-debug"
"--cflags=-O2 -gline-tables-only -fPIC -w -U_FORITFY_SOURCE
\"-fsanitize=memory\" \"-fsanitize-memory-track-origins=0\""
"--ldflags=-Wl,-z,origin -Wl,-R,XORIGIN/. \"-fsanitize=memory\""
"--cc=/mnt/data/b/build/goma/gomacc
/mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang"
"--cxx=/mnt/data/b/build/goma/gomacc
/mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang++"
"--jobs=10" "--build-method=destdir" "--run-before-build=scripts/libnspr4.sh"
mv: cannot stat `nspr/*': No such file or directory.

[pbos, 2014-09-24 20:56:12]

On 2014/09/24 17:47:41, Lei Zhang wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/598983004/ by mailto:thestig@chromium.org.
> 
> The reason for reverting is: MSAN bots failed.
> 
> FAILED: cd ../../third_party/instrumented_libraries;
> ../../third_party/instrumented_libraries/download_build_install.py
> "--product-directory=../../out/Release" "--package=libnspr4"
>
"--intermediate-directory=../../out/Release/obj/third_party/instrumented_libraries/msan-libnspr4.gen"
> "--sanitizer-type=msan" "--extra-configure-flags=--enable-64bit
--disable-debug"
> "--cflags=-O2 -gline-tables-only -fPIC -w -U_FORITFY_SOURCE
> \"-fsanitize=memory\" \"-fsanitize-memory-track-origins=0\""
> "--ldflags=-Wl,-z,origin -Wl,-R,XORIGIN/. \"-fsanitize=memory\""
> "--cc=/mnt/data/b/build/goma/gomacc
>
/mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang"
> "--cxx=/mnt/data/b/build/goma/gomacc
>
/mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang++"
> "--jobs=10" "--build-method=destdir" "--run-before-build=scripts/libnspr4.sh"
> mv: cannot stat `nspr/*': No such file or directory.

We're seeing the same thing but with this reverted (cannot stat
mozilla/nsprpub/*) on WebRTC bots with this reverted. Can you try to re-land a
version of this earthdok@, possibly by checking for the existence of
mozilla/nsprpub/* before deciding which one of these to move?

[earthdok, 2014-09-24 21:15:08]

On 2014/09/24 20:56:12, pbos wrote:
> On 2014/09/24 17:47:41, Lei Zhang wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/598983004/ by mailto:thestig@chromium.org.
> > 
> > The reason for reverting is: MSAN bots failed.
> > 
> > FAILED: cd ../../third_party/instrumented_libraries;
> > ../../third_party/instrumented_libraries/download_build_install.py
> > "--product-directory=../../out/Release" "--package=libnspr4"
> >
>
"--intermediate-directory=../../out/Release/obj/third_party/instrumented_libraries/msan-libnspr4.gen"
> > "--sanitizer-type=msan" "--extra-configure-flags=--enable-64bit
> --disable-debug"
> > "--cflags=-O2 -gline-tables-only -fPIC -w -U_FORITFY_SOURCE
> > \"-fsanitize=memory\" \"-fsanitize-memory-track-origins=0\""
> > "--ldflags=-Wl,-z,origin -Wl,-R,XORIGIN/. \"-fsanitize=memory\""
> > "--cc=/mnt/data/b/build/goma/gomacc
> >
>
/mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang"
> > "--cxx=/mnt/data/b/build/goma/gomacc
> >
>
/mnt/data/b/build/slave/Chromium_Linux_MSan_Builder/build/src/third_party/llvm-build/Release+Asserts/bin/clang++"
> > "--jobs=10" "--build-method=destdir"
"--run-before-build=scripts/libnspr4.sh"
> > mv: cannot stat `nspr/*': No such file or directory.
> 
> We're seeing the same thing but with this reverted (cannot stat
> mozilla/nsprpub/*) on WebRTC bots with this reverted. Can you try to re-land a
> version of this earthdok@, possibly by checking for the existence of
> mozilla/nsprpub/* before deciding which one of these to move?

Already done in https://codereview.chromium.org/602823002/