Source/core/dom/Fullscreen.cpp - Issue 600773002: Notify in console when an API fails because it needs to be invoked on user action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Fullscreen.cpp

Issue 600773002: Notify in console when an API fails because it needs to be invoked on user action. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed console message and rebased expected.txt files. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/pointer-lock/pointerlockelement-null-when-pending-expected.txt ('k') | Source/core/page/PointerLockController.cpp » ('j') | Source/core/page/PointerLockController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Fullscreen.cpp

diff --git a/Source/core/dom/Fullscreen.cpp b/Source/core/dom/Fullscreen.cpp

index 64b67a512ecf0eaffa02f3a1ab79bd769c43df31..d095f53cb6ecd06dfdc59fce2a126bb55e4a9b5a 100644

--- a/Source/core/dom/Fullscreen.cpp

+++ b/Source/core/dom/Fullscreen.cpp

@@ -231,8 +231,11 @@ void Fullscreen::requestFullscreen(Element& element, RequestType requestType)

// An algorithm is allowed to show a pop-up if, in the task in which the algorithm is running, either:

// - an activation behavior is currently being processed whose click event was trusted, or

// - the event listener for a trusted click event is being handled.

- if (!UserGestureIndicator::processingUserGesture())

+ if (!UserGestureIndicator::processingUserGesture()) {

+ document()->executionContext()->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel,

+ "requestFullScreen can only be initiated by a user gesture."));

Mike West 2014/09/29 12:24:08 I'd suggest pulling in 'ExceptionMessages::failedT

Mayur Kankanwadi 2014/09/30 13:56:39 Done.

break;

+ }

// Fullscreen is not supported.

if (!fullscreenIsSupported(element.document(), element))