Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: Source/core/dom/Fullscreen.cpp

Issue 600773002: Notify in console when an API fails because it needs to be invoked on user action. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments added with reset -expected.txt files. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Fullscreen.cpp
diff --git a/Source/core/dom/Fullscreen.cpp b/Source/core/dom/Fullscreen.cpp
index 64b67a512ecf0eaffa02f3a1ab79bd769c43df31..20f48fba4347a122ab4667150967c751ab4855b0 100644
--- a/Source/core/dom/Fullscreen.cpp
+++ b/Source/core/dom/Fullscreen.cpp
@@ -231,8 +231,11 @@ void Fullscreen::requestFullscreen(Element& element, RequestType requestType)
// An algorithm is allowed to show a pop-up if, in the task in which the algorithm is running, either:
// - an activation behavior is currently being processed whose click event was trusted, or
// - the event listener for a trusted click event is being handled.
- if (!UserGestureIndicator::processingUserGesture())
+ if (!UserGestureIndicator::processingUserGesture()) {
+ document()->executionContext()->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel,
+ "requestFullScreen() can only be intiated by a user gesture."));
felt 2014/09/25 08:48:39 Should we save this string "can only be initiated
Mayur Kankanwadi 2014/09/25 08:59:07 Though I haven't noticed this usage pattern before
felt 2014/09/26 05:35:46 Fine with me.
meacer 2014/09/26 17:47:38 intiated -> initiated I don't think you need pare
Mayur Kankanwadi 2014/09/29 11:22:13 Done.
break;
+ }
// Fullscreen is not supported.
if (!fullscreenIsSupported(element.document(), element))

Powered by Google App Engine
This is Rietveld 408576698