Source/core/page/PointerLockController.cpp - Issue 600773002: Notify in console when an API fails because it needs to be invoked on user action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/PointerLockController.cpp

Issue 600773002: Notify in console when an API fails because it needs to be invoked on user action. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/Fullscreen.cpp ('K') | « Source/core/dom/Fullscreen.cpp ('k') | Source/modules/notifications/Notification.cpp » ('j') | Source/modules/notifications/Notification.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/PointerLockController.cpp

diff --git a/Source/core/page/PointerLockController.cpp b/Source/core/page/PointerLockController.cpp

index 8fe61a2b9d856ee3161823457530778e31b82dbc..227730c40537a729d592aa1ac997064c76bef6ff 100644

--- a/Source/core/page/PointerLockController.cpp

+++ b/Source/core/page/PointerLockController.cpp

@@ -49,6 +49,11 @@ PassOwnPtrWillBeRawPtr<PointerLockController> PointerLockController::create(Page

void PointerLockController::requestPointerLock(Element* target)

{

+ if (!UserGestureIndicator::processingUserGesture()) {

+ target->document().executionContext()->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel,

+ "requestPointerLock() was invoked by script, without any user interaction involved!Press 'ESC' to unlock the pointer."));

meacer 2014/09/24 17:59:21 Same here as requestFullScreen

+ }

if (!target || !target->inDocument() || m_documentOfRemovedElementWhileWaitingForUnlock) {

enqueueEvent(EventTypeNames::pointerlockerror, target);

return;

« Source/core/dom/Fullscreen.cpp ('K') | « Source/core/dom/Fullscreen.cpp ('k') | Source/modules/notifications/Notification.cpp » ('j') | Source/modules/notifications/Notification.cpp » ('J')