Notify in console when an API fails because it needs to be invoked on user action.

Source/modules/notifications/Notification.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 143 matching lines @@
     return deniedPermission;
 }
 
 const String& Notification::permission(ExecutionContext* context)
 {
     return permissionString(NotificationController::clientFrom(context).checkPermission(context));
 }
 
 void Notification::requestPermission(ExecutionContext* context, PassOwnPtrWillBeRawPtr<NotificationPermissionCallback> callback)
 {
+    if (!UserGestureIndicator::processingUserGesture()) {
+        context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel,
+            "Notification.requestPermission() was invoked by script, without any user interaction involved!"));
+    }

[Peter Beverloo, 2014/09/24 14:59:44]

We removed the user gesture requirement for requesting Web Notification
permissions in M36. Are you still seeing this?

[Mayur Kankanwadi, 2014/09/24 15:03:42]

No, not seeing any permission dialog for notifications. But the issue here was
to make the user/developer aware of such a thing happening.

[Peter Beverloo, 2014/09/24 17:14:20]

I made a test-page here:
  http://peter.sh/files/notification.html

The request comes through just fine. We actually allowed this because us
requiring the gesture was not in line with the specification. Why should we warn
in this case?

[meacer, 2014/09/24 17:59:21]

I agree, a gesture isn't required for this API so no need to warn for it.

[Mayur Kankanwadi, 2014/09/25 06:43:01]

Done.

     // FIXME: Assert that this code-path will only be reached for Document environments
     // when Blink supports [Exposed] annotations on class members in IDL definitions.
     if (NotificationPermissionClient* permissionClient = NotificationPermissionClient::from(context)) {
         permissionClient->requestPermission(context, callback);
         return;
     }
 }
 
 bool Notification::dispatchEvent(PassRefPtrWillBeRawPtr<Event> event)
 {
@@ skipping 18 matching lines @@
 
     m_asyncRunner.stop();
 }
 
 bool Notification::hasPendingActivity() const
 {
     return m_state == NotificationStateShowing || m_asyncRunner.isActive();
 }
 
 } // namespace blink