Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 600753002: Remove incorrect dependency from chromeos.gyp (Closed)

Created:
6 years, 3 months ago by pneubeck (no reviews)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove incorrect dependency from chromeos.gyp During a refactoring (https://codereview.chromium.org/402403004/) by mistake a dependency of chromeos_unittests on test_support_content was added. This increased the number of files to compile from ~2200 to ~11000. BUG=NONE Committed: https://crrev.com/c7d6272c3a0448ecc04f263c05c8e0bc51d5ed31 Cr-Commit-Position: refs/heads/master@{#300113}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chromeos/chromeos.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
pneubeck (no reviews)
@Satoru, please take a look. @Denis, FYI
6 years, 3 months ago (2014-09-24 09:38:22 UTC) #2
pneubeck (no reviews)
ping
6 years, 2 months ago (2014-10-17 15:04:36 UTC) #3
satorux1
lgtm. sorry, i didn't notice.
6 years, 2 months ago (2014-10-17 16:06:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600753002/20001
6 years, 2 months ago (2014-10-17 16:08:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-17 16:13:10 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 16:13:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7d6272c3a0448ecc04f263c05c8e0bc51d5ed31
Cr-Commit-Position: refs/heads/master@{#300113}

Powered by Google App Engine
This is Rietveld 408576698