Mac: Fix history swiping bug on Yosemite.

Mac: Fix history swiping bug on Yosemite.

There are 3 different sets of callbacks generated by AppKit in response to
swipe events. The previous code relied on assumptions about the timing of the
callbacks. It expected to receive the beginGestureWithEvent: callback before
receiving any touchesMovedWithEvent: callbacks. Yosemite AppKit broke this
assumption.

The new code stops using beginGestureWithEvent: except to determine edge cases
associated with the Magic Mouse, thus removing this implicit assumption.

Because history swiping direction is determined very early on in the life cycle
of the gesture, this CL adds some logic to ensure that the direction isn't
determined prematurely.

BUG=414103
TEST=History swiping should work as expected with both magic mouse and
trackpad.

Committed: https://crrev.com/97627459714233ddb254a877760d575c997068b0
Cr-Commit-Position: refs/heads/master@{#296795}

[erikchen, 2014-09-24 22:57:19]

Patchset #1 (id:1) has been deleted

[erikchen, 2014-09-24 22:57:23]

Patchset #1 (id:20001) has been deleted

[erikchen, 2014-09-24 23:04:41]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2014-09-24 23:04:42]

avi: Please review.

[Avi (use Gerrit), 2014-09-25 04:18:35]

LGTM

[erikchen, 2014-09-25 16:52:30]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-09-25 16:53:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600743003/40001

[commit-bot: I haz the power, 2014-09-25 17:01:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-25 17:01:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2014-09-25 20:30:49]

erikchen@chromium.org changed reviewers:
+ thestig@chromium.org

[erikchen, 2014-09-25 20:30:50]

thestig: Looking for an OWNER review.

[Lei Zhang, 2014-09-25 21:12:36]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2014-09-25 21:12:37]

lgtm

https://codereview.chromium.org/600743003/diff/40001/chrome/browser/renderer_...
File
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm
(right):

https://codereview.chromium.org/600743003/diff/40001/chrome/browser/renderer_...
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm:431:
EXPECT_EQ(begin_count_, 0);
nit: EXPECT_EQ(expected, actual);

No need to fix this right now since it's almost the branch point.

[commit-bot: I haz the power, 2014-09-25 21:15:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600743003/40001

[commit-bot: I haz the power, 2014-09-25 21:21:07]

Committed patchset #1 (id:40001) as 100208ac04eebd6fd20ff443d15c72eeaab0f733

[commit-bot: I haz the power, 2014-09-25 21:21:34]

Patchset 1 (id:??) landed as
https://crrev.com/97627459714233ddb254a877760d575c997068b0
Cr-Commit-Position: refs/heads/master@{#296795}