[Invalidation Tracking] add TraceEvents for setNeedsStyleRecalc.

[Invalidation Tracking] add TraceEvents for setNeedsStyleRecalc.

Depends on http://crrev.com/547823002 .

This CL introduces a devtools.timeline TraceEvent for Node::setNeedsStyleRecalc.

The TraceEvent is going to be used in devtools to track style invalidation reasons.
Please see the bug for more info.

BUG=410701
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183059

[kouhei (in TOK), 2014-09-29 09:13:23]

kouhei@chromium.org changed reviewers:
+ caseq@chromium.org, pdr@chromium.org

[kouhei (in TOK), 2014-09-29 09:13:24]

PTAL. This CL adds the trace events for
https://codereview.chromium.org/547823002/

[pdr., 2014-09-29 17:27:07]

On 2014/09/29 09:13:24, kouhei wrote:
> PTAL. This CL adds the trace events for
> https://codereview.chromium.org/547823002/

LGTM, though we will need to wait for caseq's LGTM as well.

[pdr., 2014-09-30 01:51:21]

https://codereview.chromium.org/600733005/diff/1/Source/core/dom/Node.cpp
File Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/600733005/diff/1/Source/core/dom/Node.cpp#new...
Source/core/dom/Node.cpp:777: if (changeType > existingChangeType) {
We may want to do this for all changes, not just ones with changeType >
existingChangeType.

https://codereview.chromium.org/600733005/diff/1/Source/core/dom/Node.cpp#new...
Source/core/dom/Node.cpp:779: if (changeType >= SubtreeStyleChange) {
Is this correct? What about LocalStyleChanges?

https://codereview.chromium.org/600733005/diff/1/Source/core/dom/Node.cpp#new...
Source/core/dom/Node.cpp:786: // FIXME: Remove below
Fixed! https://src.chromium.org/viewvc/blink?revision=182859&view=revision

[kouhei (in TOK), 2014-09-30 02:01:54]

https://codereview.chromium.org/600733005/diff/1/Source/core/dom/Node.cpp
File Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/600733005/diff/1/Source/core/dom/Node.cpp#new...
Source/core/dom/Node.cpp:777: if (changeType > existingChangeType) {
On 2014/09/30 01:51:20, pdr wrote:
> We may want to do this for all changes, not just ones with changeType >
> existingChangeType.

Done.

https://codereview.chromium.org/600733005/diff/1/Source/core/dom/Node.cpp#new...
Source/core/dom/Node.cpp:779: if (changeType >= SubtreeStyleChange) {
On 2014/09/30 01:51:20, pdr wrote:
> Is this correct? What about LocalStyleChanges?

Done.

https://codereview.chromium.org/600733005/diff/1/Source/core/dom/Node.cpp#new...
Source/core/dom/Node.cpp:786: // FIXME: Remove below
On 2014/09/30 01:51:20, pdr wrote:
> Fixed! https://src.chromium.org/viewvc/blink?revision=182859&view=revision

Thanks!

[pdr., 2014-09-30 03:25:48]

More comments as I'm adding this to the prototype. Sorry for the churn this is
causing you :/

https://codereview.chromium.org/600733005/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorTraceEvents.cpp (right):

https://codereview.chromium.org/600733005/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorTraceEvents.cpp:71: RefPtr<TracedValue> value =
TracedValue::create();
Can you add value->setString("frame", toHexString(node->document().frame()));
here?

https://codereview.chromium.org/600733005/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorTraceEvents.h (right):

https://codereview.chromium.org/600733005/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorTraceEvents.h:35: class
InspectorStyleRecalcInvalidationTrackingEvent {
Ultra mega nit: Can we move this down near its invalidation friends?

[kouhei (in TOK), 2014-09-30 03:49:33]

https://codereview.chromium.org/600733005/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorTraceEvents.cpp (right):

https://codereview.chromium.org/600733005/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorTraceEvents.cpp:71: RefPtr<TracedValue> value =
TracedValue::create();
On 2014/09/30 03:25:48, pdr wrote:
> Can you add value->setString("frame", toHexString(node->document().frame()));
> here?

Done.

https://codereview.chromium.org/600733005/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorTraceEvents.h (right):

https://codereview.chromium.org/600733005/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorTraceEvents.h:35: class
InspectorStyleRecalcInvalidationTrackingEvent {
On 2014/09/30 03:25:48, pdr wrote:
> Ultra mega nit: Can we move this down near its invalidation friends?

Done.

[pdr., 2014-09-30 03:52:13]

LGTM from my side. I added this to the prototype if you'd like to give it a
spin: https://codereview.chromium.org/465223002

[kouhei (in TOK), 2014-10-01 04:20:53]

caseq: Would you take a look?

On 2014/09/30 03:52:13, pdr wrote:
> LGTM from my side. I added this to the prototype if you'd like to give it a
> spin: https://codereview.chromium.org/465223002
Thanks!

[caseq, 2014-10-01 08:34:05]

lgtm

[kouhei (in TOK), 2014-10-01 09:08:48]

Thanks for review!

[kouhei (in TOK), 2014-10-01 09:08:52]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-10-01 09:09:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600733005/40001

[commit-bot: I haz the power, 2014-10-01 11:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-01 11:24:24]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/29683)

[kouhei (in TOK), 2014-10-01 11:29:49]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-10-01 11:30:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600733005/40001

[commit-bot: I haz the power, 2014-10-01 13:23:41]

Committed patchset #3 (id:40001) as 183059