Issue 600733004: Rename GetUsersAdmittedForMultiProfile to GetUsersAllowedForMultiProfile

Issue 600733004: Rename GetUsersAdmittedForMultiProfile to GetUsersAllowedForMultiProfile (Closed)

Created:
6 years, 3 months ago by Roman Sorokin (ftl)

Modified:
6 years, 2 months ago

Reviewers:
James Cook, Nikita (slow), ygorshenin1

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rename GetUsersAdmittedForMultiProfile to GetUsersAllowedForMultiProfile BUG=397105 Committed: https://crrev.com/c21feee5ab49c4ae58c19296a9a840859b6b0994 Cr-Commit-Position: refs/heads/master@{#297400}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -16 lines)			Patch
M	chrome/browser/chromeos/login/ui/login_display_host_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/users/chrome_user_manager_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/users/fake_user_manager.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/users/fake_user_manager.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/users/mock_user_manager.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/ash/session_state_delegate_chromeos.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/system_tray_delegate_chromeos.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	components/user_manager/user_manager.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 11 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ygorshenin1

LGTM as soon as chrome/browser/ui/ash/session_state_delegate_chromeos.cc:89 will be fixed.

6 years, 2 months ago (2014-09-26 08:31:22 UTC) #3

James Cook

LGTM once compile error fixed https://codereview.chromium.org/600733004/diff/1/components/user_manager/user_manager.h File components/user_manager/user_manager.h (right): https://codereview.chromium.org/600733004/diff/1/components/user_manager/user_manager.h#newcode108 components/user_manager/user_manager.h:108: // Returns list of ...

6 years, 2 months ago (2014-09-26 18:02:28 UTC) #4

Roman Sorokin (ftl)

Nikita, please review chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc

6 years, 2 months ago (2014-09-29 07:39:29 UTC) #6

Nikita (slow)

On 2014/09/29 07:39:29, Roman Sorokin wrote: > Nikita, please review > chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc lgtm using TBR ...

6 years, 2 months ago (2014-09-29 15:07:50 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600733004/20001

6 years, 2 months ago (2014-09-30 10:15:20 UTC) #9

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 58f25a8945f699cc36ccbaa087b8dd118ea9c3bb

6 years, 2 months ago (2014-09-30 10:53:24 UTC) #10

commit-bot: I haz the power

6 years, 2 months ago (2014-09-30 10:54:10 UTC) #11

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/c21feee5ab49c4ae58c19296a9a840859b6b0994
Cr-Commit-Position: refs/heads/master@{#297400}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages