Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Issue 600733002: Revert of EventSender: Added checks for missing arguments (Closed)

Created:
6 years, 3 months ago by Mads Ager (chromium)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, bokan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of EventSender: Added checks for missing arguments (patchset #4 id:60001 of https://codereview.chromium.org/584203003/) Reason for revert: This makes the fast/events/hit-test-counts.html layout test fail. Reverting for now. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fevents%2Fhit-test-counts.html&testType=layout-tests Original issue's description: > Added checks for missing arguments in event_sender.cc. Also simplified the uses of x & y in EventSender::GestureEvent. > > BUG=415970 > > Committed: https://crrev.com/302907463636d2ddfe25c5381bd1f2b64016d1c6 > Cr-Commit-Position: refs/heads/master@{#296256} TBR=dpranke@chromium.org,rbyers@chromium.org,earthdok@chromium.org,mustaq@chromium.org NOTREECHECKS=true NOTRY=true BUG=415970 Committed: https://crrev.com/f70f5fb877a526a7df23caf02831c1e9635b0fb3 Cr-Commit-Position: refs/heads/master@{#296357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -30 lines) Patch
M content/shell/renderer/test_runner/event_sender.cc View 11 chunks +25 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (chromium)
Created Revert of EventSender: Added checks for missing arguments
6 years, 3 months ago (2014-09-24 07:02:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600733002/1
6 years, 3 months ago (2014-09-24 07:03:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d6e3d513e4faef3439483473cbf0f465b0d15b9d
6 years, 3 months ago (2014-09-24 07:03:35 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 07:04:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f70f5fb877a526a7df23caf02831c1e9635b0fb3
Cr-Commit-Position: refs/heads/master@{#296357}

Powered by Google App Engine
This is Rietveld 408576698