Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl.h

Issue 600693002: content: Cleanup GpuMemoryBufferImpl destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gpu_memory_buffer_impl.h
diff --git a/content/common/gpu/client/gpu_memory_buffer_impl.h b/content/common/gpu/client/gpu_memory_buffer_impl.h
index 2da6b437e8ac60d44a70e441632fafb29918cfc8..0beab681883516a337d832f3413fc8ee51acffb0 100644
--- a/content/common/gpu/client/gpu_memory_buffer_impl.h
+++ b/content/common/gpu/client/gpu_memory_buffer_impl.h
@@ -19,6 +19,7 @@ class GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
CreationCallback;
typedef base::Callback<void(const gfx::GpuMemoryBufferHandle& handle)>
AllocationCallback;
+ typedef base::Closure DestructionCallback;
virtual ~GpuMemoryBufferImpl();
@@ -50,7 +51,8 @@ class GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
static scoped_ptr<GpuMemoryBufferImpl> CreateFromHandle(
const gfx::GpuMemoryBufferHandle& handle,
const gfx::Size& size,
- unsigned internalformat);
+ unsigned internalformat,
+ const DestructionCallback& callback);
piman 2014/09/24 03:19:10 nit: I think it should be documented explicitly th
reveman 2014/09/24 06:03:38 Done.
// Returns true if |internalformat| is a format recognized by this base class.
static bool IsFormatValid(unsigned internalformat);

Powered by Google App Engine
This is Rietveld 408576698