Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4498)

Unified Diff: chrome/browser/tabs/tab_strip_model_unittest.cc

Issue 60066: Make the throbber throb sooner after you navigate. This fixes the new tab pag... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tabs/tab_strip_model_unittest.cc
===================================================================
--- chrome/browser/tabs/tab_strip_model_unittest.cc (revision 13028)
+++ chrome/browser/tabs/tab_strip_model_unittest.cc (working copy)
@@ -274,7 +274,8 @@
virtual void TabDetachedAt(TabContents* contents, int index) {
states_.push_back(new State(contents, index, DETACH));
}
- virtual void TabChangedAt(TabContents* contents, int index) {
+ virtual void TabChangedAt(TabContents* contents, int index,
+ bool loading_only) {
states_.push_back(new State(contents, index, CHANGE));
}
virtual void TabStripEmpty() {
@@ -465,7 +466,7 @@
// Test UpdateTabContentsStateAt
{
- tabstrip.UpdateTabContentsStateAt(0);
+ tabstrip.UpdateTabContentsStateAt(0, false);
EXPECT_EQ(1, observer.GetStateCount());
State s1(replacement_contents2, 0, MockTabStripModelObserver::CHANGE);
EXPECT_TRUE(observer.StateEquals(0, s1));

Powered by Google App Engine
This is Rietveld 408576698