Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 600653002: [NaCl SDK AppEngine] Fix PNaCl demos after html5 onpopstate change. (Closed)

Created:
6 years, 3 months ago by binji
Modified:
6 years, 3 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK AppEngine] Fix PNaCl demos after html5 onpopstate change. window.onpopstate used to be called with a null state when a page was loaded for the first time. This was a bug, and inconsistent with other browsers, but we relied on it in the PNaCl demo page. Without it, direct links to a demo page were not working properly. Even after fixing this, I ran into issues with history when creating/destroying a new iframe element whenever the page switched. Using iframe.contentDocument.location.replace seems to have fixed these issues. No trybots because this only affects the AppEngine demo page. BUG=none R=sbc@chromium.org NOTRY=true Committed: https://crrev.com/4d1fef58494b664d1ba514c52fd0606498d67a5f Cr-Commit-Position: refs/heads/master@{#296526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M native_client_sdk/src/gonacl_appengine/static/frame.js View 3 chunks +17 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
6 years, 3 months ago (2014-09-24 00:20:56 UTC) #1
binji
ping
6 years, 3 months ago (2014-09-24 21:23:36 UTC) #2
Sam Clegg
lgtm
6 years, 3 months ago (2014-09-24 21:27:50 UTC) #3
binji
Committed patchset #1 (id:1) manually as 4d1fef5 (presubmit successful).
6 years, 3 months ago (2014-09-24 21:34:19 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 21:34:20 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d1fef58494b664d1ba514c52fd0606498d67a5f
Cr-Commit-Position: refs/heads/master@{#296526}

Powered by Google App Engine
This is Rietveld 408576698