Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 600643002: Override drawImage*() in SkNWayCanvas (Closed)

Created:
6 years, 3 months ago by Rémi Piotaix
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Correcting nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M include/utils/SkNWayCanvas.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
reed1
lgtm w/ nit https://codereview.chromium.org/600643002/diff/1/include/utils/SkNWayCanvas.h File include/utils/SkNWayCanvas.h (right): https://codereview.chromium.org/600643002/diff/1/include/utils/SkNWayCanvas.h#newcode40 include/utils/SkNWayCanvas.h:40: const SkPaint* paint = NULL) SK_OVERRIDE; ...
6 years, 2 months ago (2014-09-29 12:50:25 UTC) #2
Rémi Piotaix
https://codereview.chromium.org/600643002/diff/1/include/utils/SkNWayCanvas.h File include/utils/SkNWayCanvas.h (right): https://codereview.chromium.org/600643002/diff/1/include/utils/SkNWayCanvas.h#newcode40 include/utils/SkNWayCanvas.h:40: const SkPaint* paint = NULL) SK_OVERRIDE; On 2014/09/29 12:50:25, ...
6 years, 2 months ago (2014-09-29 15:42:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600643002/20001
6 years, 2 months ago (2014-09-29 15:43:21 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 15:56:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as b7bac3d015cd1c85343d6c49316bfd942efa3f9f

Powered by Google App Engine
This is Rietveld 408576698