sandbox: Avoid ~(flag1 | flag2 | ...) expressions

sandbox: Avoid ~(flag1 | flag2 | ...) expressions

BUG=416948
Committed: https://crrev.com/046a627acf6d3f091c70694b78e98c3874d06258
Cr-Commit-Position: refs/heads/master@{#296262}

[mdempsky, 2014-09-23 20:33:07]

mdempsky@chromium.org changed reviewers:
+ jln@chromium.org

[jln (very slow on Chromium), 2014-09-23 21:04:31]

Good catch!

Is there a reason to not use uint64 everywhere?

lgtm

https://codereview.chromium.org/600583002/diff/1/components/nacl/loader/nonsf...
File components/nacl/loader/nonsfi/nonsfi_sandbox.cc (right):

https://codereview.chromium.org/600583002/diff/1/components/nacl/loader/nonsf...
components/nacl/loader/nonsfi/nonsfi_sandbox.cc:64: const unsigned long
kAllowedMask = O_ACCMODE | O_NONBLOCK;
uint64 for consistency ?

https://codereview.chromium.org/600583002/diff/1/sandbox/linux/bpf_dsl/bpf_dsl.h
File sandbox/linux/bpf_dsl/bpf_dsl.h (right):

https://codereview.chromium.org/600583002/diff/1/sandbox/linux/bpf_dsl/bpf_ds...
sandbox/linux/bpf_dsl/bpf_dsl.h:46: //            const unsigned long kGoodFlags
= O_ACCMODE | O_NONBLOCK;
uint64?

[mdempsky, 2014-09-23 21:17:16]

On 2014/09/23 21:04:31, jln (slow on IPC reviews) wrote:
> Is there a reason to not use uint64 everywhere?

Nope, and I actually already did that with patch set 2. :)

https://codereview.chromium.org/600583002/diff/1/components/nacl/loader/nonsf...
File components/nacl/loader/nonsfi/nonsfi_sandbox.cc (right):

https://codereview.chromium.org/600583002/diff/1/components/nacl/loader/nonsf...
components/nacl/loader/nonsfi/nonsfi_sandbox.cc:64: const unsigned long
kAllowedMask = O_ACCMODE | O_NONBLOCK;
On 2014/09/23 21:04:30, jln (slow on IPC reviews) wrote:
> uint64 for consistency ?

Done.

https://codereview.chromium.org/600583002/diff/1/sandbox/linux/bpf_dsl/bpf_dsl.h
File sandbox/linux/bpf_dsl/bpf_dsl.h (right):

https://codereview.chromium.org/600583002/diff/1/sandbox/linux/bpf_dsl/bpf_ds...
sandbox/linux/bpf_dsl/bpf_dsl.h:46: //            const unsigned long kGoodFlags
= O_ACCMODE | O_NONBLOCK;
On 2014/09/23 21:04:31, jln (slow on IPC reviews) wrote:
> uint64?

Done.

[mdempsky, 2014-09-23 21:17:21]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2014-09-23 21:19:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600583002/20001

[commit-bot: I haz the power, 2014-09-23 21:45:59]

Committed patchset #2 (id:20001) as 59aadc5e8d500241253ce6de13f40cb99eddf4a1

[commit-bot: I haz the power, 2014-09-23 21:47:07]

Patchset 2 (id:??) landed as
https://crrev.com/046a627acf6d3f091c70694b78e98c3874d06258
Cr-Commit-Position: refs/heads/master@{#296262}