Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 600553003: Enable swapping a frame back in to its parent process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remoteToLocal
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_per_process_browsertest.cc
diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc
index dacbad3a580bfb9258f1a54d3174380476eacdfb..145a24989e38d3e9a892162161c3f22a647c6f6c 100644
--- a/content/browser/site_per_process_browsertest.cc
+++ b/content/browser/site_per_process_browsertest.cc
@@ -337,13 +337,13 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, NavigateRemoteFrame) {
EXPECT_NE(site_instance,
child->current_frame_host()->GetSiteInstance());
- // TODO(japhet): This currently causes an assertion in the renderer process.
- // Enable when the assertion is fixed.
- //NavigateFrameToURL(child, http_url);
- //EXPECT_EQ(http_url, observer.navigation_url());
- //EXPECT_TRUE(observer.navigation_succeeded());
- //EXPECT_EQ(shell()->web_contents()->GetSiteInstance(),
- // child->current_frame_host()->GetSiteInstance());
+ // Navigate back to the parent's origin and ensure we return to the
+ // parent's process.
+ NavigateFrameToURL(child, http_url);
+ EXPECT_EQ(http_url, observer.navigation_url());
+ EXPECT_TRUE(observer.navigation_succeeded());
+ EXPECT_EQ(shell()->web_contents()->GetSiteInstance(),
+ child->current_frame_host()->GetSiteInstance());
}
// Crash a subframe and ensures its children are cleared from the FrameTree.
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698