Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: content/renderer/render_frame_impl.h

Issue 600553003: Enable swapping a frame back in to its parent process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remoteToLocal
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 9457afc5736fea05ce9e60443f86850b9e326c86..a8255aadef46a48ceadc541f08653f3f9bd656aa 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -104,12 +104,16 @@ class CONTENT_EXPORT RenderFrameImpl
// Creates a new RenderFrame with |routing_id| as a child of the RenderFrame
// identified by |parent_routing_id| or as the top-level frame if the latter
- // is MSG_ROUTING_NONE. It creates the Blink WebLocalFrame and inserts it in
- // the proper place in the frame tree.
+ // is MSG_ROUTING_NONE. If proxy_routing_id is MSG_ROUTING_NONE, it creates
+ // the Blink WebLocalFrame and inserts it in the proper place in the frame
+ // tree. Otherwise, the frame is semi-orphaned until it commits, at which
+ // point it replaces the given proxy.
nasko 2014/10/27 22:52:55 nit: s/the given proxy/the proxy identified by |pr
Nate Chapin 2014/10/28 19:59:20 Done.
// Note: This is called only when RenderFrame is being created in response to
// IPC message from the browser process. All other frame creation is driven
// through Blink and Create.
- static void CreateFrame(int routing_id, int parent_routing_id);
+ static void CreateFrame(int routing_id,
+ int parent_routing_id,
+ int proxy_routing_id);
// Returns the RenderFrameImpl for the given routing ID.
static RenderFrameImpl* FromRoutingID(int routing_id);
@@ -670,6 +674,10 @@ class CONTENT_EXPORT RenderFrameImpl
RenderFrameProxy* render_frame_proxy_;
bool is_detaching_;
+ // If this frame was created to replace a proxy, this will store the routing
+ // id of the proxy to replace at commit-time.
Charlie Reis 2014/10/28 16:38:29 Unfortunate that we have to store this. I suppose
Nate Chapin 2014/10/28 19:59:20 Done.
+ int proxy_routing_id_;
+
#if defined(ENABLE_PLUGINS)
// Current text input composition text. Empty if no composition is in
// progress.

Powered by Google App Engine
This is Rietveld 408576698