Support hotwording on google.com and the new tab page.

chrome/browser/resources/hotword/constants.js

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('hotword.constants', function() {
 'use strict';
 
 /**
  * Hotword data shared module extension's ID.
  * @const {string}
  */
 var SHARED_MODULE_ID = 'lccekmodgklaepjeofjdjpbminllajkg';
 
 /**
  * Path to shared module data.
  * @const {string}
  */
 var SHARED_MODULE_ROOT = '_modules/' + SHARED_MODULE_ID;
 
 /**
+ * Name used by the content scripts to create communications Ports.
+ * @const {string}
+ */
+var CLIENT_PORT_NAME = 'chwcpn';
+
+/**
+ * The field name to specify the command among pages.
+ * @const {string}
+ */
+var COMMAND_FIELD_NAME = 'cmd';
+
+/**
  * Time to wait for expected messages, in milliseconds.
  * @enum {number}
  */
 var TimeoutMs = {
   SHORT: 200,
   NORMAL: 500,
   LONG: 2000
 };
 
 /**
@@ skipping 35 matching lines @@
   STOP: 's',
   REQUEST_MODEL: 'model',
   MODEL_LOADED: 'model_loaded',
   READY_FOR_AUDIO: 'audio',
   STOPPED: 'stopped',
   HOTWORD_DETECTED: 'hotword',
   MS_CONFIGURED: 'ms_configured'
 };
 
 /**
+ * Messages sent from the injected scripts to the Google page.
+ * @enum {string}
+ */
+var CommandToPage = {
+  HOTWORD_VOICE_TRIGGER: 'vt',
+  HOTWORD_STARTED: 'hs',
+  HOTWORD_ENDED: 'hd',
+  HOTWORD_TIMEOUT: 'ht',
+  HOTWORD_ERROR: 'he'
+};
+
+/**
+ * Messages sent from the Google page to the injected scripts
+ * and then passed to the extension.
+ * @enum {string}
+ */
+var CommandFromPage = {
+  SPEECH_START: 'ss',
+  SPEECH_END: 'se',
+  SPEECH_RESET: 'sr',
+  SHOWING_HOTWORD_START: 'shs',
+  SHOWING_ERROR_MESSAGE: 'sem',
+  SHOWING_TIMEOUT_MESSAGE: 'stm',
+  CLICKED_RESUME: 'hcc',
+  CLICKED_RESTART: 'hcr',
+  CLICKED_DEBUG: 'hcd',
+  WAKE_UP_HELPER: 'wuh'
+};
+
+/**
  * Source of a hotwording session request.
  * @enum {string}
  */
 var SessionSource = {
-  LAUNCHER: 'launcher'
+  LAUNCHER: 'launcher',
+  NTP: 'ntp'
 };
 
 /**
  * The browser UI language.
  * @const {string}
  */
 var UI_LANGUAGE = (chrome.i18n && chrome.i18n.getUILanguage) ?
       chrome.i18n.getUILanguage() : '';
 
 return {
   SHARED_MODULE_ID: SHARED_MODULE_ID,
   SHARED_MODULE_ROOT: SHARED_MODULE_ROOT,
+  CLIENT_PORT_NAME: CLIENT_PORT_NAME,
+  COMMAND_FIELD_NAME: COMMAND_FIELD_NAME,

[Dan Beam, 2014/10/09 22:43:58]

nit: alphabetize

[Anand Mistry (off Chromium), 2014/10/10 23:11:44]

Done.

[Dan Beam, 2014/10/11 00:54:35]

thanks for doing this.

what you have works, but I meant:

  return {
    ... CONSTANTS_ALPHABETIZED_WITHIN_THEIR_OWN_LIST ...
    ... EnumsAlphabetizedWithinTheirOwnList ...
  };

sorry, you had absolutely 0 way of knowing that :/.

also, ideally the initialization/declaration order of each value in the file
would also match the order in the return {...};, e.g.,

  /** Spooky. */
  var HALLOWEEN = 1;

  /** Oooky. */
  var SCARES_SMALL_CHILDREN = 2;

  /** Very. */
  var Candy = {BabyRuth: 'no', MilkyWay: 'teeth'};

  /** Scary. */
  var Costumes = {Frankenstein: 1, Ghost: 2};

  return {
    HALLOWEEN: HALLOWEEN,
    SCARES_SMALL_CHILDREN: SCARES_SMALL_CHILDREN,
    Candy: Candy,
    Costumes: Costumes,
  }

feel free to do this separately.  it's not a huge deal.

[Anand Mistry (off Chromium), 2014/10/13 19:30:20]

Gotcha! Fixed that.
Yeah, I'll do this in a separate CL.

   TimeoutMs: TimeoutMs,
   File: File,
   Error: Error,
   Event: Event,
   NaClPlugin: NaClPlugin,
+  CommandToPage: CommandToPage,
+  CommandFromPage: CommandFromPage,
   SessionSource: SessionSource,
   UI_LANGUAGE: UI_LANGUAGE
 };
 
 });