Chromium Code Reviews

Issue 600513002: Simplify media/audio-concurrent-supported.html thanks to r182442. (Closed)

Created:
6 years, 2 months ago by scherkus (not reviewing)
Modified:
6 years, 2 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Project:
blink
Visibility:
Public.

Description

Simplify media/audio-concurrent-supported.html thanks to r182442. The first periodic timeupdate event now reliably fires only when currentTime is non-zero. No need to do this silly "count the number of timeupdate events and make assumptions about how things work" dance. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182577

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+16 lines, -17 lines)
M LayoutTests/media/audio-concurrent-supported.html View 3 chunks +14 lines, -17 lines 0 comments
M LayoutTests/media/audio-concurrent-supported-expected.txt View 1 chunk +2 lines, -0 lines 0 comments

Messages

Total messages: 6 (2 generated)
scherkus (not reviewing)
6 years, 2 months ago (2014-09-23 18:26:29 UTC) #2
philipj_slow
lgtm yay
6 years, 2 months ago (2014-09-24 08:20:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600513002/1
6 years, 2 months ago (2014-09-24 08:21:01 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 10:09:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182577

Powered by Google App Engine