Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 600503002: Cleanup unused data reduction proxy entries from gypi file. (Closed)

Created:
6 years, 3 months ago by Not at Google. Contact bengr
Modified:
6 years, 2 months ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup unused data reduction proxy entries from gypi file. Dependency on these entries was removed in https://codereview.chromium.org/382313003/ BUG=412890 Committed: https://crrev.com/87bc7a8a882fed491e97229c0b051597f45fcf13 Cr-Commit-Position: refs/heads/master@{#297459}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -65 lines) Patch
M build/common.gypi View 4 chunks +0 lines, -65 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
Not at Google. Contact bengr
bengr: build/common.gypi
6 years, 3 months ago (2014-09-23 18:38:58 UTC) #2
bengr
https://codereview.chromium.org/600503002/diff/1/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/600503002/diff/1/build/common.gypi#oldcode988 build/common.gypi:988: 'spdy_proxy_auth_origin%': 'https://proxy.googlezip.net:443/', Does webview still work with the data ...
6 years, 3 months ago (2014-09-24 17:48:41 UTC) #3
Not at Google. Contact bengr
https://codereview.chromium.org/600503002/diff/1/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/600503002/diff/1/build/common.gypi#oldcode988 build/common.gypi:988: 'spdy_proxy_auth_origin%': 'https://proxy.googlezip.net:443/', On 2014/09/24 17:48:41, bengr1 wrote: > Does ...
6 years, 2 months ago (2014-09-29 23:51:43 UTC) #4
bengr
lgtm
6 years, 2 months ago (2014-09-30 18:10:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600503002/1
6 years, 2 months ago (2014-09-30 18:17:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as ae04bb725fb1b1c28086d5df7103ab3af715c4bf
6 years, 2 months ago (2014-09-30 18:24:20 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:25:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87bc7a8a882fed491e97229c0b051597f45fcf13
Cr-Commit-Position: refs/heads/master@{#297459}

Powered by Google App Engine
This is Rietveld 408576698