Cross-platform equivalent of fopen, _wfopen_s etc....

base/trace_event.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event.h"
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/platform_thread.h"
 #include "base/process_util.h"
@@ skipping 31 matching lines @@
 bool TraceLog::StartTracing() {
   TraceLog* trace = Singleton<TraceLog>::get();
   return trace->Start();
 }
 
 bool TraceLog::Start() {
   if (enabled_)
     return true;
   enabled_ = OpenLogFile();
   if (enabled_) {
     Log("var raw_trace_events = [\r\n");

[Mark Mentovai, 2008/10/01 17:40:55]

Followup patch to get rid of the \r or only emit it on Windows?

(Might be worth looking over the codebase for other \rs.)

     trace_start_time_ = TimeTicks::Now();
     timer_.Start(TimeDelta::FromMilliseconds(250), this, &TraceLog::Heartbeat);
   }
   return enabled_;
 }
 
 // static
 void TraceLog::StopTracing() {
   TraceLog* trace = Singleton<TraceLog>::get();
   return trace->Stop();
 }
 
 void TraceLog::Stop() {
   if (enabled_) {
     enabled_ = false;
     Log("];\r\n");
     CloseLogFile();
     timer_.Stop();
   }
 }
 
 void TraceLog::Heartbeat() {
   std::string cpu = StringPrintf("%d", process_metrics_->GetCPUUsage());
   TRACE_EVENT_INSTANT("heartbeat.cpu", 0, cpu);
 }
 
 void TraceLog::CloseLogFile() {
   if (log_file_) {
-#if defined(OS_WIN)
-    ::CloseHandle(log_file_);
-#elif defined(OS_POSIX)
-    fclose(log_file_);
-#endif
+    file_util::CloseFile(log_file_);

[Mark Mentovai, 2008/10/01 17:40:55]

log_file_ is declared as a FileHandle, which is not FILE* on Windows.  Fixing
that in trace_event.h.

   }
 }
 
 bool TraceLog::OpenLogFile() {
   std::wstring pid_filename =
     StringPrintf(kLogFileName, process_util::GetCurrentProcId());
   std::wstring log_file_name;
   PathService::Get(base::DIR_EXE, &log_file_name);
   file_util::AppendToPath(&log_file_name, pid_filename);
-#if defined(OS_WIN)
-  log_file_ = ::CreateFile(log_file_name.c_str(), GENERIC_WRITE,
-                           FILE_SHARE_READ | FILE_SHARE_WRITE, NULL,
-                           OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
-  if (log_file_ == INVALID_HANDLE_VALUE || log_file_ == NULL) {
+  log_file_ = file_util::OpenFile(log_file_name, "a");
+  if (!log_file_) {
     // try the current directory
-    log_file_ = ::CreateFile(pid_filename.c_str(), GENERIC_WRITE,
-                             FILE_SHARE_READ | FILE_SHARE_WRITE, NULL,
-                             OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
-    if (log_file_ == INVALID_HANDLE_VALUE || log_file_ == NULL) {
-      log_file_ = NULL;
+    log_file_ = file_util::OpenFile(pid_filename, "a");
+    if (!log_file_) {
       return false;
     }
   }
-  ::SetFilePointer(log_file_, 0, 0, FILE_END);
-#elif defined(OS_POSIX)
-  log_file_ = fopen(WideToUTF8(log_file_name).c_str(), "a");
-  if (log_file_ == NULL)
-    return false;
-#endif
   return true;
 }
 
 void TraceLog::Trace(const std::string& name, 
                      EventType type,
                      const void* id,
                      const std::wstring& extra,
                      const char* file, 
                      int line) {
   if (!enabled_)
@@ skipping 30 matching lines @@
                  file, 
                  line,
                  usec);
 
   Log(msg);
 }
 
 void TraceLog::Log(const std::string& msg) {
   AutoLock lock(file_lock_);
 
-#if defined (OS_WIN)
-  SetFilePointer(log_file_, 0, 0, SEEK_END);
-  DWORD num;
-  WriteFile(log_file_, (void*)msg.c_str(), (DWORD)msg.length(), &num, NULL);
-#elif defined (OS_POSIX)
   fprintf(log_file_, "%s", msg.c_str());
-#endif
 }
 
 } // namespace base