Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 600483003: Do not create proxy hosts in the subtree of navigating frame. (Closed)

Created:
6 years, 3 months ago by nasko
Modified:
6 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, creis+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nasko+codewatch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not create proxy hosts in the subtree of navigating frame. This is an another attempt at landing https://codereview.chromium.org/536143002. When a frame is navigating cross-process, its existing document will be completely destroyed and all child frames will be gone. This means that we don't need to create proxy objects for the new SiteInstance in the subtree of the navigating frame. BUG=357747, 417030 Committed: https://crrev.com/e6edde315c6cb57cae5f67056191dceab3f7403b Cr-Commit-Position: refs/heads/master@{#300112}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Init to null. #

Patch Set 3 : Rebase past CommitPending cleanup. #

Patch Set 4 : Restore proxy deletion after rebase #

Patch Set 5 : Rebase on ToT. #

Patch Set 6 : Fix NavigateRemoteFrame. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -19 lines) Patch
M content/browser/accessibility/site_per_process_accessibility_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_tree.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 1 2 3 4 5 3 chunks +15 lines, -7 lines 0 comments Download
M content/browser/frame_host/frame_tree_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 3 4 5 1 chunk +19 lines, -5 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 3 4 5 7 chunks +125 lines, -4 lines 0 comments Download
M content/test/data/site_per_process_main.html View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nasko
Hey Charlie, This is an attempt to reland the change to avoid creating proxies in ...
6 years, 3 months ago (2014-09-24 21:34:44 UTC) #2
Charlie Reis
LGTM https://codereview.chromium.org/600483003/diff/1/content/browser/site_per_process_browsertest.cc File content/browser/site_per_process_browsertest.cc (right): https://codereview.chromium.org/600483003/diff/1/content/browser/site_per_process_browsertest.cc#newcode632 content/browser/site_per_process_browsertest.cc:632: SiteInstance* site; nit: Please initialize this to null.
6 years, 3 months ago (2014-09-24 21:59:36 UTC) #3
nasko
https://codereview.chromium.org/600483003/diff/1/content/browser/site_per_process_browsertest.cc File content/browser/site_per_process_browsertest.cc (right): https://codereview.chromium.org/600483003/diff/1/content/browser/site_per_process_browsertest.cc#newcode632 content/browser/site_per_process_browsertest.cc:632: SiteInstance* site; On 2014/09/24 21:59:36, Charlie Reis wrote: > ...
6 years, 2 months ago (2014-09-25 16:20:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600483003/100001
6 years, 2 months ago (2014-10-17 15:10:50 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 2 months ago (2014-10-17 15:37:07 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 15:38:02 UTC) #8
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e6edde315c6cb57cae5f67056191dceab3f7403b
Cr-Commit-Position: refs/heads/master@{#300112}

Powered by Google App Engine
This is Rietveld 408576698