Source/core/loader/PingLoader.cpp - Issue 600393004: [ServiceWorker] Set FetchRequestMode and handle wasFetchedViaServiceWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/PingLoader.cpp

Issue 600393004: [ServiceWorker] Set FetchRequestMode and handle wasFetchedViaServiceWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add setFetchCredentialsMode in PingLoader::PingLoader() Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/PingLoader.cpp

diff --git a/Source/core/loader/PingLoader.cpp b/Source/core/loader/PingLoader.cpp

index bea722bf6faea6434e5a0cdcfc8d8956e07dafe3..e5d2aa30b785d291003fe87ce7d8011e89c23952 100644

--- a/Source/core/loader/PingLoader.cpp

+++ b/Source/core/loader/PingLoader.cpp

@@ -146,6 +146,7 @@ PingLoader::PingLoader(LocalFrame* frame, ResourceRequest& request, const FetchI

ASSERT(m_loader);

blink::WrappedResourceRequest wrappedRequest(request);

wrappedRequest.setAllowStoredCredentials(credentialsAllowed == AllowStoredCredentials);

+ wrappedRequest.setFetchCredentialsMode(credentialsAllowed == AllowStoredCredentials ? WebURLRequest::FetchCredentialsModeInclude : WebURLRequest::FetchCredentialsModeSameOrigin);

yhirano 2014/10/07 08:03:15 Can you tell me why same-origin is indicated when

m_loader->loadAsynchronously(wrappedRequest, this);

// If the server never responds, FrameLoader won't be able to cancel this load and

« Source/core/loader/DocumentThreadableLoader.cpp ('K') | « Source/core/loader/DocumentThreadableLoader.cpp ('k') | no next file » | no next file with comments »