Source/core/fetch/CrossOriginAccessControl.cpp - Issue 600393004: [ServiceWorker] Set FetchRequestMode and handle wasFetchedViaServiceWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fetch/CrossOriginAccessControl.cpp

Issue 600393004: [ServiceWorker] Set FetchRequestMode and handle wasFetchedViaServiceWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add setFetchCredentialsMode in PingLoader::PingLoader() Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/test-helpers.js ('k') | Source/core/fetch/FetchRequest.cpp » ('j') | Source/core/loader/DocumentThreadableLoader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/fetch/CrossOriginAccessControl.cpp

diff --git a/Source/core/fetch/CrossOriginAccessControl.cpp b/Source/core/fetch/CrossOriginAccessControl.cpp

index 92dafdf3c2b1fd90666bf3e51d2bb958c8e265ab..fea74afa1deee3859fb8646668940d051919eddb 100644

--- a/Source/core/fetch/CrossOriginAccessControl.cpp

+++ b/Source/core/fetch/CrossOriginAccessControl.cpp

@@ -65,6 +65,7 @@ void updateRequestForAccessControl(ResourceRequest& request, SecurityOrigin* sec

{

request.removeCredentials();

request.setAllowStoredCredentials(allowCredentials == AllowStoredCredentials);

yhirano 2014/10/07 08:03:14 Requiring to call two methods in all occurrences m

+ request.setFetchCredentialsMode(allowCredentials == AllowStoredCredentials ? WebURLRequest::FetchCredentialsModeInclude : WebURLRequest::FetchCredentialsModeSameOrigin);

yhirano 2014/10/07 08:03:14 This behavior (setting same-origin if allowCredent

if (securityOrigin)

request.setHTTPOrigin(securityOrigin->toAtomicString());