Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 600383002: [turbofan] Add backend support for Float32Constant. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add backend support for Float32Constant. TEST=cctest,compiler-unittests,mjsunit BUG=v8:3589 LOG=n R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24217

Patch Set 1 #

Patch Set 2 : Add InstructionSelector unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -23 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 4 chunks +26 lines, -8 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 3 chunks +26 lines, -10 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +18 lines, -1 line 0 comments Download
M src/compiler/instruction.h View 2 chunks +14 lines, -1 line 0 comments Download
M src/compiler/instruction.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/instruction-selector-unittest.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector-unittest.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 4 chunks +20 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-25 08:19:03 UTC) #1
Michael Starzinger
LGTM.
6 years, 3 months ago (2014-09-25 08:54:40 UTC) #2
Benedikt Meurer
6 years, 3 months ago (2014-09-25 08:56:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24217 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698