Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 600363002: Add extensions/common/stack_frame_unittest.cc to extensions.gyp. (Closed)

Created:
6 years, 3 months ago by Sam McNally
Modified:
6 years, 2 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add extensions/common/stack_frame_unittest.cc to extensions.gyp. Committed: https://crrev.com/987f416b9727c5697604bdcf94adcbdaf025ec7c Cr-Commit-Position: refs/heads/master@{#296829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M extensions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/stack_frame_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam McNally
6 years, 3 months ago (2014-09-25 07:29:01 UTC) #2
Devlin
LGTM. Thanks for catching this.
6 years, 2 months ago (2014-09-25 16:20:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600363002/1
6 years, 2 months ago (2014-09-25 23:28:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as be21ec020d024132fa8c8b0e8e96a77e366da828
6 years, 2 months ago (2014-09-25 23:34:22 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 23:34:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/987f416b9727c5697604bdcf94adcbdaf025ec7c
Cr-Commit-Position: refs/heads/master@{#296829}

Powered by Google App Engine
This is Rietveld 408576698