Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Unified Diff: Source/core/platform/animation/TimingFunction.h

Issue 60033004: Don't check all animation/transition properties when comparing RenderStyles (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/platform/animation/CSSAnimationData.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/platform/animation/TimingFunction.h
diff --git a/Source/core/platform/animation/TimingFunction.h b/Source/core/platform/animation/TimingFunction.h
index 1f9a398a9cafb3d32fd418d1aa9b33cb32bc7641..3394fffe9662c672d1c7ac6b5abf24c77401c332 100644
--- a/Source/core/platform/animation/TimingFunction.h
+++ b/Source/core/platform/animation/TimingFunction.h
@@ -52,7 +52,6 @@ public:
// Evaluates the timing function at the given fraction. The accuracy parameter provides a hint as to the required
// accuracy and is not guaranteed.
virtual double evaluate(double fraction, double accuracy) const = 0;
- virtual bool operator==(const TimingFunction& other) const = 0;
protected:
TimingFunction(Type type)
@@ -80,11 +79,6 @@ public:
return fraction;
}
- virtual bool operator==(const TimingFunction& other) const
- {
- return other.type() == LinearFunction;
- }
-
private:
LinearTimingFunction()
: TimingFunction(LinearFunction)
@@ -151,18 +145,6 @@ public:
return m_bezier->solve(fraction, accuracy);
}
- virtual bool operator==(const TimingFunction& other) const
- {
- if (other.type() == CubicBezierFunction) {
- const CubicBezierTimingFunction* ctf = static_cast<const CubicBezierTimingFunction*>(&other);
- if (m_subType != Custom)
- return m_subType == ctf->m_subType;
-
- return m_x1 == ctf->m_x1 && m_y1 == ctf->m_y1 && m_x2 == ctf->m_x2 && m_y2 == ctf->m_y2;
- }
- return false;
- }
-
double x1() const { return m_x1; }
double y1() const { return m_y1; }
double x2() const { return m_x2; }
@@ -231,17 +213,6 @@ public:
return std::min(1.0, (floor(m_steps * fraction) + m_stepAtStart) / m_steps);
}
- virtual bool operator==(const TimingFunction& other) const
- {
- if (other.type() == StepsFunction) {
- const StepsTimingFunction* stf = static_cast<const StepsTimingFunction*>(&other);
- if (m_subType != Custom)
- return m_subType == stf->m_subType;
- return m_steps == stf->m_steps && m_stepAtStart == stf->m_stepAtStart;
- }
- return false;
- }
-
int numberOfSteps() const { return m_steps; }
bool stepAtStart() const { return m_stepAtStart; }
@@ -287,13 +258,6 @@ public:
return segment->evaluate(fraction, accuracy);
}
- virtual bool operator==(const TimingFunction& other) const
- {
- // This class is not exposed to CSS, so this method is not required.
- ASSERT_NOT_REACHED();
- return false;
- }
-
private:
class Segment {
public:
« no previous file with comments | « Source/core/platform/animation/CSSAnimationData.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698