Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 600303003: mac: Add metrics for fullscreen entry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add another parameter to the metric. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 777b0e692e918a9723a6a860c31d704e413d3b4f..f5a4c572d05470e8e4bb90cf109cb19d17a75d75 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -21323,6 +21323,18 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<summary>Events seen by the OSX NSException swizzle.</summary>
</histogram>
+<histogram name="OSX.Fullscreen.Enter" enum="OSXFullscreenParameters">
+ <owner>erikchen@chromium.org</owner>
+ <summary>
+ This event is recorded each time a user triggers fullscreen for a browser
+ window. The value's bits reflect different parameters. Bit 0: Fullscreen
+ entry mechanism (AppKit vs Immersive). Bit 1: Whether the window was on the
+ primary screen (Primary vs. Secondary). Bit 2: Whether displays have
+ separate spaces options is enabled (Seperate vs Shared). Bit 3: Whether
+ there are multiple screens.
+ </summary>
+</histogram>
+
<histogram name="OSX.SystemHotkeyMap.LoadSuccess" enum="BooleanSuccess">
<owner>erikchen@chromium.org</owner>
<summary>
@@ -47891,6 +47903,45 @@ To add a new entry, add it with any value and run test to compute valid value.
</int>
</enum>
+<enum name="OSXFullscreenParameters" type="int">
+ <int value="2" label="IMMERSIVE_PRIMARY_SHARED_SINGLE">
+ Immersive Mechanism + Primary Screen + Shared Spaces + Single Screen
+ </int>
+ <int value="3" label="APPKIT_PRIMARY_SHARED_SINGLE">
+ AppKit Mechanism + Primary Screen + Shared Spaces + Single Screen
+ </int>
+ <int value="6" label="IMMERSIVE_PRIMARY_SEPARATE_SINGLE">
+ Immersive Mechanism + Primary Screen + Separate Spaces + Single Screen
+ </int>
+ <int value="7" label="APPKIT_PRIMARY_SEPARATE_SINGLE">
+ AppKit Mechanism + Primary Screen + Separate Spaces + Single Screen
+ </int>
+ <int value="8" label="IMMERSIVE_SECONDARY_SHARED_MULTIPLE">
+ Immersive Mechanism + Secondary Screen + Shared Spaces + Multiple Screens
+ </int>
+ <int value="9" label="APPKIT_SECONDARY_SHARED_MULTIPLE">
+ AppKit Mechanism + Secondary Screen + Shared Spaces + Multiple Screens
+ </int>
+ <int value="10" label="IMMERSIVE_PRIMARY_SHARED_MULTIPLE">
+ Immersive Mechanism + Primary Screen + Shared Spaces + Multiple Screens
+ </int>
+ <int value="11" label="APPKIT_PRIMARY_SHARED_MULTIPLE">
+ AppKit Mechanism + Primary Screen + Shared Spaces + Multiple Screens
+ </int>
+ <int value="12" label="IMMERSIVE_SECONDARY_SEPARATE_MULTIPLE">
+ Immersive Mechanism + Secondary Screen + Separate Spaces + Multiple Screens
+ </int>
+ <int value="13" label="APPKIT_SECONDARY_SEPARATE_MULTIPLE">
+ AppKit Mechanism + Secondary Screen + Separate Spaces + Multiple Screens
+ </int>
+ <int value="14" label="IMMERSIVE_PRIMARY_SEPARATE_MULTIPLE">
+ Immersive Mechanism + Primary Screen + Separate Spaces + Multiple Screens
+ </int>
+ <int value="15" label="APPKIT_PRIMARY_SEPARATE_MULTIPLE">
+ AppKit Mechanism + Primary Screen + Separate Spaces + Multiple Screens
+ </int>
+</enum>
+
<enum name="OtherPossibleUsernamesUsage" type="int">
<int value="0" label="Nothing to Autofill"/>
<int value="1" label="No other possible usernames"/>

Powered by Google App Engine
This is Rietveld 408576698